All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: jejb@linux.ibm.com, Luo Jiaxing <luojiaxing@huawei.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	linuxarm@huawei.com, linux-scsi@vger.kernel.org,
	yanaijie@huawei.com, chenxiang66@hisilicon.com,
	john.garry@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] scsi: libsas: set data_dir as DMA_NONE if libata mark qc as NODATA
Date: Wed,  2 Sep 2020 23:01:01 -0400	[thread overview]
Message-ID: <159910202092.23499.14266650737882130791.b4-ty@oracle.com> (raw)
In-Reply-To: <1598426666-54544-1-git-send-email-luojiaxing@huawei.com>

On Wed, 26 Aug 2020 15:24:26 +0800, Luo Jiaxing wrote:

> We found that it will fail every time when set feature to SATA disk by
> "sdparm -s WCE=0 /dev/sde".
> 
> After checking protocol, we know that MODE SELECT is the SCSI command for
> setting WCE, and it do not exist in the SATA protocol. Therefore, this
> commands are encapsulated in the SET FEATURE command in SATA protocol.
> The difference is that the MODE SELECT command sent to SAS disk contains
> data and is sent through the DMA. But when send to SATA disk through
> SET FEATURE command, it does not contain data.
> 
> [...]

Applied to 5.9/scsi-fixes, thanks!

[1/1] scsi: libsas: Set data_dir as DMA_NONE if libata marks qc as NODATA
      https://git.kernel.org/mkp/scsi/c/53de092f47ff

-- 
Martin K. Petersen	Oracle Linux Engineering

      parent reply	other threads:[~2020-09-03  3:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26  7:24 [PATCH v1] scsi: libsas: set data_dir as DMA_NONE if libata mark qc as NODATA Luo Jiaxing
2020-08-31  7:29 ` Jason Yan
2020-09-03  3:01 ` Martin K. Petersen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159910202092.23499.14266650737882130791.b4-ty@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=jejb@linux.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=luojiaxing@huawei.com \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.