From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Daniel Vetter" <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_managed, leftovers
Date: Fri, 04 Sep 2020 15:08:25 -0000 [thread overview]
Message-ID: <159923210585.8517.13527663905376816607@emeril.freedesktop.org> (raw)
In-Reply-To: <20200904143941.110665-1-daniel.vetter@ffwll.ch>
== Series Details ==
Series: drm_managed, leftovers
URL : https://patchwork.freedesktop.org/series/81371/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7e79337308df drm/armada: Use devm_drm_dev_alloc
-:68: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 45 lines checked
26f00c197367 drm/armada: Don't use drm_device->dev_private
-:165: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 112 lines checked
987c9338ca7b drm/aspeed: Use managed drmm_mode_config_cleanup
-:64: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 40 lines checked
86684c96f0be drm/vgem: Use devm_drm_dev_alloc
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13:
This also somewhat untangles the load code, since the drm and platform device
total: 0 errors, 1 warnings, 0 checks, 88 lines checked
07047c4d2081 drm/vkms: Use devm_drm_dev_alloc
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13:
This also somewhat untangles the load code, since the drm and platform device
-:136: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 104 lines checked
d837a22748b5 drm/xlnx: Use devm_drm_dev_alloc
-:63: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 39 lines checked
796ee493a8a3 drm/i915/selftest: Create mock_destroy_device
-:184: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 106 lines checked
124bff980d17 drm/i915/selftests: align more to real device lifetimes
-:92: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 66 lines checked
9fa6eafa5dc7 drm/dev: Remove drm_dev_init
c15b464eaef1 drm/arc: Switch to devm_drm_dev_alloc
-:103: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 75 lines checked
746009dbe330 drm/arc: Stop using drm_device->dev_private
-:69: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 40 lines checked
fe06aeaae2bd drm/arc: Delete arcpgu_priv->fb
be543cb2845f drm/arc: Embedded a drm_simple_display_pipe
-:135: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 93 lines checked
a17149e448e8 drm/arc: Embedd a drm_connector for sim case
-:64: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 39 lines checked
ba16b70d40cc drm/arc: Drop surplus connector registration
5c8bfba805ad drm/arc: Use drmm_mode_config_cleanup
-:122: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 83 lines checked
d11e78dcb76b drm/arc: Align with simple pipe helpers
-:60: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 35 lines checked
2431d7d612ac drm/arc: Convert to drm_simple_kms_pipe_helper
-:294: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 242 lines checked
5bb83c222569 drm/arc: Drop crtc check in arc_pgu_update
-:28: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
5e3a85368a5d drm/arc: Inline arcpgu_crtc.c
-:43: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
deleted file mode 100644
-:235: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#235: FILE: drivers/gpu/drm/arc/arcpgu_drv.c:39:
+ uint32_t pixel_format = fb->format->format;
-:264: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rate > 0'
#264: FILE: drivers/gpu/drm/arc/arcpgu_drv.c:68:
+ if ((max(rate, clk_rate) - min(rate, clk_rate) < diff) && (rate > 0))
-:331: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#331: FILE: drivers/gpu/drm/arc/arcpgu_drv.c:135:
+ arc_pgu_write(arcpgu, ARCPGU_REG_CTRL,
+ arc_pgu_read(arcpgu, ARCPGU_REG_CTRL) &
-:373: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 3 checks, 170 lines checked
8b0c4a52a621 drm/arc: Inline arcpgu_drm_hdmi_init
-:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#58:
deleted file mode 100644
-:89: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 29 lines checked
a561f0af936b drm/arc: Inline remaining files
-:26: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#26:
deleted file mode 100644
-:171: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#171: FILE: drivers/gpu/drm/arc/arcpgu_drv.c:111:
+ ret = drm_connector_init(drm, connector, &arcpgu_drm_connector_funcs,
+ DRM_MODE_CONNECTOR_VIRTUAL);
-:304: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 1 checks, 117 lines checked
e22fc3f4bb1b drm/arc: Initialize sim connector before display pipe
-:111: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 87 lines checked
686a533fcde6 drm/arc: Move to drm/tiny
-:53: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#53:
deleted file mode 100644
-:84: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully
#84: FILE: drivers/gpu/drm/tiny/Kconfig:3:
+config DRM_ARCPGU
-:111: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 3 warnings, 0 checks, 44 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-04 15:08 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 14:39 [PATCH 00/24] drm_managed, leftovers Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 01/24] drm/armada: Use devm_drm_dev_alloc Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-10 1:20 ` Dave Airlie
2020-09-10 1:20 ` [Intel-gfx] " Dave Airlie
2020-09-04 14:39 ` [PATCH 02/24] drm/armada: Don't use drm_device->dev_private Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 03/24] drm/aspeed: Use managed drmm_mode_config_cleanup Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` Daniel Vetter
2020-09-04 14:39 ` [PATCH 04/24] drm/vgem: Use devm_drm_dev_alloc Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-09 11:01 ` Melissa Wen
2020-09-09 11:01 ` [Intel-gfx] " Melissa Wen
2020-09-09 11:20 ` Daniel Vetter
2020-09-09 11:20 ` [Intel-gfx] " Daniel Vetter
2020-09-09 16:29 ` Melissa Wen
2020-09-09 16:29 ` [Intel-gfx] " Melissa Wen
2020-09-09 12:07 ` [PATCH] " Daniel Vetter
2020-09-09 12:07 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 05/24] drm/vkms: " Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-08 23:42 ` Melissa Wen
2020-09-08 23:42 ` [Intel-gfx] " Melissa Wen
2020-09-09 9:18 ` [PATCH] " Daniel Vetter
2020-09-09 9:18 ` [Intel-gfx] " Daniel Vetter
2020-09-09 9:22 ` Melissa Wen
2020-09-09 9:22 ` [Intel-gfx] " Melissa Wen
2020-09-04 14:39 ` [PATCH 06/24] drm/xlnx: " Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` Daniel Vetter
2020-09-07 8:22 ` [PATCH] " Daniel Vetter
2020-09-07 8:22 ` [Intel-gfx] " Daniel Vetter
2020-09-07 8:22 ` Daniel Vetter
2020-09-08 19:16 ` Hyun Kwon
2020-09-08 19:16 ` [Intel-gfx] " Hyun Kwon
2020-09-08 19:16 ` Hyun Kwon
2020-09-11 8:47 ` Daniel Vetter
2020-09-11 8:47 ` [Intel-gfx] " Daniel Vetter
2020-09-11 8:47 ` Daniel Vetter
2020-09-04 14:39 ` [PATCH 07/24] drm/i915/selftest: Create mock_destroy_device Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 08/24] drm/i915/selftests: align more to real device lifetimes Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-11 8:59 ` Maarten Lankhorst
2020-09-11 8:59 ` Maarten Lankhorst
2020-09-11 9:08 ` Matthew Auld
2020-09-11 9:08 ` Matthew Auld
2020-09-04 14:39 ` [PATCH 09/24] drm/dev: Remove drm_dev_init Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 10/24] drm/arc: Switch to devm_drm_dev_alloc Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-10-23 12:31 ` Daniel Vetter
2020-10-23 12:31 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 11/24] drm/arc: Stop using drm_device->dev_private Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 15:09 ` Daniel Vetter
2020-09-04 15:09 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 12/24] drm/arc: Delete arcpgu_priv->fb Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 13/24] drm/arc: Embedded a drm_simple_display_pipe Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 14/24] drm/arc: Embedd a drm_connector for sim case Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 15/24] drm/arc: Drop surplus connector registration Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 16/24] drm/arc: Use drmm_mode_config_cleanup Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 17/24] drm/arc: Align with simple pipe helpers Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 18/24] drm/arc: Convert to drm_simple_kms_pipe_helper Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 19/24] drm/arc: Drop crtc check in arc_pgu_update Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 20/24] drm/arc: Inline arcpgu_crtc.c Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 21/24] drm/arc: Inline arcpgu_drm_hdmi_init Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 22/24] drm/arc: Inline remaining files Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 23/24] drm/arc: Initialize sim connector before display pipe Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-04 14:39 ` [PATCH 24/24] drm/arc: Move to drm/tiny Daniel Vetter
2020-09-04 14:39 ` [Intel-gfx] " Daniel Vetter
2020-09-09 7:54 ` Thomas Zimmermann
2020-09-09 7:54 ` [Intel-gfx] " Thomas Zimmermann
2020-09-04 15:08 ` Patchwork [this message]
2020-09-04 15:09 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm_managed, leftovers Patchwork
2020-09-04 15:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-05 3:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-07 9:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_managed, leftovers (rev2) Patchwork
2020-09-07 9:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-09-07 9:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-09 9:45 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm_managed, leftovers (rev3) Patchwork
2020-09-09 12:11 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm_managed, leftovers (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159923210585.8517.13527663905376816607@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.