All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: linux-kernel@vger.kernel.org, Rich Felker <dalias@libc.org>
Cc: Kees Cook <keescook@chromium.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>
Subject: Re: [PATCH] seccomp: kill process instead of thread for unknown actions
Date: Tue,  8 Sep 2020 12:43:43 -0700	[thread overview]
Message-ID: <159959421548.1668991.14680355869966635620.b4-ty@chromium.org> (raw)
In-Reply-To: <20200829015609.GA32566@brightrain.aerifal.cx>

On Fri, 28 Aug 2020 21:56:13 -0400, Rich Felker wrote:
> Asynchronous termination of a thread outside of the userspace thread
> library's knowledge is an unsafe operation that leaves the process in
> an inconsistent, corrupt, and possibly unrecoverable state. In order
> to make new actions that may be added in the future safe on kernels
> not aware of them, change the default action from
> SECCOMP_RET_KILL_THREAD to SECCOMP_RET_KILL_PROCESS.

Applied, thanks!

[1/1] seccomp: kill process instead of thread for unknown actions
      https://git.kernel.org/kees/c/4d671d922d51

I tweaked the coredump logic and added a selftest (and CCed you) for
the behavior (since it wasn't included in the existing tests).

-- 
Kees Cook


      parent reply	other threads:[~2020-09-08 19:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29  1:56 [PATCH] seccomp: kill process instead of thread for unknown actions Rich Felker
2020-08-31 19:36 ` Kees Cook
2020-09-08  4:34   ` Kyle Huey
2020-09-08 19:43 ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159959421548.1668991.14680355869966635620.b4-ty@chromium.org \
    --to=keescook@chromium.org \
    --cc=dalias@libc.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.