Re: [PULL 00/44] Python patches

From: John Snow <jsnow@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	Qemu-block <qemu-block@nongnu.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PULL 00/44] Python patches
Date: Sun, 30 May 2021 15:22:01 -0400	[thread overview]
Message-ID: <15baf57f-3372-a617-61f3-66c3bb42a302@redhat.com> (raw)
In-Reply-To: <CAFEAcA_Kws=q73Yhe-AeuGhtx3V0uQOwaEG9+oRvcaROed8uNg@mail.gmail.com>

On 5/30/21 3:09 PM, Peter Maydell wrote:
> On Fri, 28 May 2021 at 03:32, John Snow <jsnow@redhat.com> wrote:
>>
>> The following changes since commit c8616fc7670b884de5f74d2767aade224c1c5c3a:
>>
>>    Merge remote-tracking branch 'remotes/philmd/tags/gitlab-ci-20210527' into staging (2021-05-27 16:32:57 +0100)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/jsnow/qemu.git tags/python-pull-request
>>
>> for you to fetch changes up to faa40e297406445ab8814844bd9aa532a7538cde:
>>
>>    gitlab: add python linters to CI (2021-05-27 18:11:17 -0400)
>>
>> ----------------------------------------------------------------
>> Python pull request
>>
>> Python packaging & CI implementation
>> Acceptance tests sent w/ Cleber's blessing.
>> New CI tests send w/ stsquad's RB.
>>
>> --js
>>
>> ----------------------------------------------------------------
> 
> Fails to build on my machine that runs the BSD VMs, apparently
> before it gets to the point of launching the VM:
> 
> make: Entering directory '/home/peter.maydell/qemu-freebsd/build'
> /usr/bin/python3 -B /home/peter.maydell/qemu-freebsd/meson/meson.py
> introspect --targets --tests --benchmarks | /usr/bin/python3 -B
> scripts/mtest2make.py > Makefile.mtest
> { \
>    echo 'ninja-targets = \'; \
>    /usr/bin/ninja -t targets all | sed 's/:.*//; $!s/$/ \\/'; \
>    echo 'build-files = \'; \
>    /usr/bin/ninja -t query build.ninja | sed -n '1,/^  input:/d; /^
> outputs:/q; s/$/ \\/p'; \
> } > Makefile.ninja.tmp && mv Makefile.ninja.tmp Makefile.ninja
> (GIT="git" "/home/peter.maydell/qemu-freebsd/scripts/git-submodule.sh"
> update ui/keycodemapdb meson tests/fp/berkeley-testfloat-3
> tests/fp/berkeley-softfloat-3 dtc capstone slirp)
> (GIT="git" "/home/peter.maydell/qemu-freebsd/scripts/git-submodule.sh"
> update ui/keycodemapdb meson tests/fp/berkeley-testfloat-3
> tests/fp/berkeley-softfloat-3 dtc capstone slirp)
> /usr/bin/python3 -B /home/peter.maydell/qemu-freebsd/tests/vm/freebsd
> --debug --genisoimage /usr/bin/genisoimage    --image
> "/home/peter.maydell/.cache/qemu-vm/images/freebsd.img" --force
> --build-image /home/peter.maydell/.cache/qemu-vm/images/freebsd.img
> Traceback (most recent call last):
>    File "/home/peter.maydell/qemu-freebsd/tests/vm/freebsd", line 21, in <module>
>      import basevm
>    File "/home/peter.maydell/qemu-freebsd/tests/vm/basevm.py", line 22,
> in <module>
>      from qemu.machine import QEMUMachine
> ImportError: bad magic number in 'qemu': b'\x03\xf3\r\n'
> /home/peter.maydell/qemu-freebsd/tests/vm/Makefile.include:79: recipe
> for target '/home/peter.maydell/.cache/qemu-vm/images/freebsd.img'
> failed
> make: *** [/home/peter.maydell/.cache/qemu-vm/images/freebsd.img] Error 1
> make: Leaving directory '/home/peter.maydell/qemu-freebsd/build'
> 
> thanks
> -- PMM
> 

Hmm ...

When I have seen this error message in the past, it has been because of 
using a new Python version and it gets confused reading stale cached 
information generated from an older interpreter.

None of these patches *should* have affected what version of python is 
used during the build, only the locations of some of the files. I don't 
immediately know why this PR would affect the QEMU build at all, actually.

Can you do me a favor and delete any __pycache__ folders and/or any 
*.pyc files that might be hiding in your tree and/or build folders and 
try running it again?

(If it helps, I can see about amending 'make clean' to try and clean up 
stale Python cache, which is the best solution I can think of for right 
now.)

In case that doesn't fix it, can you tell me what version of Python your 
BSD setup uses? (And what version of FreeBSD you use?) -- I'll try to 
set up a VM and see if I can reproduce the problem.

--js