Re: [PATCH v3 3/3] soc: loongson2_pm: add power management support

From: zhuyinbo <zhuyinbo@loongson.cn>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	zhuyinbo@loongson.cn, Conor Dooley <conor+dt@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@ucw.cz>, Marc Zyngier <maz@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
	Jianmin Lv <lvjianmin@loongson.cn>,
	wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
	loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v3 3/3] soc: loongson2_pm: add power management support
Date: Fri, 16 Jun 2023 12:01:56 +0800	[thread overview]
Message-ID: <15c4c3cf-819b-c298-c212-d58b1e28ccd8@loongson.cn> (raw)
In-Reply-To: <CAAhV-H4-LCryuQKJrwE65w5BZ66a6PQAq+ZT8mqE7vHa7L3_zw@mail.gmail.com>

在 2023/6/16 上午9:54, Huacai Chen 写道:
> Hi, Yinbo,
> 
> On Fri, Jun 16, 2023 at 9:45 AM zhuyinbo <zhuyinbo@loongson.cn> wrote:

...

>>>
>>>
>>> okay, I got it.
>>>
>>>>
>>>>> +}
>>>>> +
>>>>> +static void loongson2_power_button_irq_enable(void)
>>>>
>>>> Using loongson2_pm_irq_enable is a little better.
>>>
>>>
>>
>> Previously, you suggested that I combine loongson2_pm_irq_enable() and
>> power button irq enable code as loongson2_power_button_irq_enable, then
>> I remove the function loongson2_pm_irq_enable, in this case that I won't
>> be able to call loongson2_pm_irq_enable, so have I misunderstood your
>> meaning ? or only rename loongson2_power_button_irq_enable as
>> loongson2_pm_irq_enable ?
> I'm very sorry for that. At first I only wanted to combine two
> functions, but then I found the name  loongson2_pm_irq_enable is
> better. So just rename is OK. Thanks.
> 

okay, I got it.

Thanks,
Yinbo