All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 0/9] Cleanup metadata page reading path
Date: Mon, 14 Sep 2020 14:39:56 +0300	[thread overview]
Message-ID: <15fdb3d7-b7e4-bb00-c410-11e871cd9820@suse.com> (raw)
In-Reply-To: <SN4PR0401MB3598C03BCB90A41366EE4E4E9B230@SN4PR0401MB3598.namprd04.prod.outlook.com>



On 14.09.20 г. 13:39 ч., Johannes Thumshirn wrote:
> On 14/09/2020 11:37, Nikolay Borisov wrote:
>> Here is v2 of the metadata readout cleanups [0]. This series incorporates the
>> feedback I received, namely:
>>
>> * Added justification why removing btree_readpage is safe in Patch 1
>> * Dropped Patch 2 (pg_offset remove from btrfs_get_extent) as Qu intends on using
>> it in his subpage blocksize work.
>> * Add a comment about caller's responsibility for cleanup in Patch 3
>> * Added RB for patches which haven't changed since v1 and got RB by Josef.
>>
>> [0] https://lore.kernel.org/linux-btrfs/20200909094914.29721-1-nborisov@suse.com/T/#t
> 
> Apart from the nit in 7/9
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 


I believe your feedback has been addressed by the follow on patch I just
sent.

  reply	other threads:[~2020-09-14 11:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14  9:37 [PATCH v2 0/9] Cleanup metadata page reading path Nikolay Borisov
2020-09-14  9:37 ` [PATCH v2 1/9] btrfs: Remove btree_readpage Nikolay Borisov
2020-09-14 10:51   ` Qu Wenruo
2020-09-14  9:37 ` [PATCH v2 2/9] btrfs: Simplify metadata pages reading Nikolay Borisov
2020-09-14 11:01   ` Qu Wenruo
2020-09-14  9:37 ` [PATCH v2 3/9] btrfs: Remove btree_get_extent Nikolay Borisov
2020-09-14  9:37 ` [PATCH v2 4/9] btrfs: Remove btrfs_get_extent indirection from __do_readpage Nikolay Borisov
2020-09-14  9:37 ` [PATCH v2 5/9] btrfs: Remove mirror_num argument from extent_read_full_page Nikolay Borisov
2020-09-14  9:37 ` [PATCH v2 6/9] btrfs: Promote extent_read_full_page to btrfs_readpage Nikolay Borisov
2020-09-14  9:37 ` [PATCH v2 7/9] btrfs: Sink mirror_num argument in extent_read_full_page Nikolay Borisov
2020-09-14 10:35   ` Johannes Thumshirn
2020-09-14 10:38     ` Nikolay Borisov
2020-09-14  9:37 ` [PATCH v2 8/9] btrfs: Sink read_flags argument into extent_read_full_page Nikolay Borisov
2020-09-14  9:37 ` [PATCH v2 9/9] btrfs: Sink mirror_num argument in __do_readpage Nikolay Borisov
2020-09-14 10:39 ` [PATCH v2 0/9] Cleanup metadata page reading path Johannes Thumshirn
2020-09-14 11:39   ` Nikolay Borisov [this message]
2020-09-14 11:44     ` Johannes Thumshirn
2020-09-14 11:39 ` [PATCH] btrfs: Opencode extent_read_full_page to its sole caller Nikolay Borisov
2020-09-14 11:45   ` Johannes Thumshirn
2020-09-15  7:44   ` David Sterba
2020-09-15  7:43 ` [PATCH v2 0/9] Cleanup metadata page reading path David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15fdb3d7-b7e4-bb00-c410-11e871cd9820@suse.com \
    --to=nborisov@suse.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.