From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Thomas Zimmermann" <tzimmermann@suse.de>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-buf: Flag vmap'ed memory as system or I/O memory (rev2)
Date: Wed, 23 Sep 2020 13:25:38 -0000 [thread overview]
Message-ID: <160086753865.4494.7661567529708955822@emeril.freedesktop.org> (raw)
In-Reply-To: <20200923123205.30671-1-tzimmermann@suse.de>
== Series Details ==
Series: dma-buf: Flag vmap'ed memory as system or I/O memory (rev2)
URL : https://patchwork.freedesktop.org/series/81647/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
757ce74a1b9b dma-buf: Add struct dma-buf-map for storing struct dma_buf.vaddr_ptr
-:52: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#52: FILE: drivers/dma-buf/dma-buf.c:1212:
+ BUG_ON(dma_buf_map_is_null(&dmabuf->vmap_ptr));
-:58: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#58: FILE: drivers/dma-buf/dma-buf.c:1217:
+ BUG_ON(dma_buf_map_is_set(&dmabuf->vmap_ptr));
-:76: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#76: FILE: drivers/dma-buf/dma-buf.c:1244:
+ BUG_ON(dma_buf_map_is_null(&dmabuf->vmap_ptr));
-:79: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#79: FILE: drivers/dma-buf/dma-buf.c:1246:
+ BUG_ON(!dma_buf_map_is_vaddr(&dmabuf->vmap_ptr, vaddr));
-:91: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#91:
new file mode 100644
-:145: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!map->vaddr_iomem"
#145: FILE: include/linux/dma-buf-map.h:50:
+ return map->vaddr_iomem == NULL;
-:146: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!map->vaddr"
#146: FILE: include/linux/dma-buf-map.h:51:
+ return map->vaddr == NULL;
total: 0 errors, 5 warnings, 2 checks, 152 lines checked
3ed40eba3c1e dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfaces
a23bd28000a3 dma-buf: Use struct dma_buf_map in dma_buf_vunmap() interfaces
-:43: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#43: FILE: drivers/dma-buf/dma-buf.c:1250:
+ BUG_ON(!dma_buf_map_is_equal(&dmabuf->vmap_ptr, map));
total: 0 errors, 1 warnings, 0 checks, 287 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-23 13:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 12:32 [PATCH v2 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory Thomas Zimmermann
2020-09-23 12:32 ` [Intel-gfx] " Thomas Zimmermann
2020-09-23 12:32 ` Thomas Zimmermann
2020-09-23 12:32 ` [PATCH v2 1/3] dma-buf: Add struct dma-buf-map for storing struct dma_buf.vaddr_ptr Thomas Zimmermann
2020-09-23 12:32 ` [Intel-gfx] " Thomas Zimmermann
2020-09-23 12:32 ` Thomas Zimmermann
2020-09-23 14:27 ` Christian König
2020-09-23 14:27 ` [Intel-gfx] " Christian König
2020-09-23 14:27 ` Christian König
2020-09-23 15:37 ` Daniel Vetter
2020-09-23 15:37 ` [Intel-gfx] " Daniel Vetter
2020-09-23 15:37 ` Daniel Vetter
2020-09-25 11:32 ` Thomas Zimmermann
2020-09-25 11:32 ` [Intel-gfx] " Thomas Zimmermann
2020-09-25 11:32 ` Thomas Zimmermann
2020-09-23 12:32 ` [PATCH v2 2/3] dma-buf: Use struct dma_buf_map in dma_buf_vmap() interfaces Thomas Zimmermann
2020-09-23 12:32 ` [Intel-gfx] " Thomas Zimmermann
2020-09-23 12:32 ` Thomas Zimmermann
2020-09-23 14:30 ` Christian König
2020-09-23 14:30 ` [Intel-gfx] " Christian König
2020-09-23 14:30 ` Christian König
2020-09-23 15:39 ` Daniel Vetter
2020-09-23 15:39 ` [Intel-gfx] " Daniel Vetter
2020-09-23 15:39 ` Daniel Vetter
2020-09-24 7:14 ` Thomas Zimmermann
2020-09-24 7:14 ` [Intel-gfx] " Thomas Zimmermann
2020-09-24 7:14 ` Thomas Zimmermann
2020-09-23 16:19 ` kernel test robot
2020-09-24 0:36 ` kernel test robot
2020-09-23 12:32 ` [PATCH v2 3/3] dma-buf: Use struct dma_buf_map in dma_buf_vunmap() interfaces Thomas Zimmermann
2020-09-23 12:32 ` [Intel-gfx] " Thomas Zimmermann
2020-09-23 12:32 ` Thomas Zimmermann
2020-09-23 15:40 ` Daniel Vetter
2020-09-23 15:40 ` [Intel-gfx] " Daniel Vetter
2020-09-23 15:40 ` Daniel Vetter
2020-09-23 13:25 ` Patchwork [this message]
2020-09-23 13:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for dma-buf: Flag vmap'ed memory as system or I/O memory (rev2) Patchwork
2020-09-23 18:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160086753865.4494.7661567529708955822@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.