From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Daniel Vetter" <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/radeon: Stop changing the drm_driver struct
Date: Fri, 23 Oct 2020 13:39:59 -0000 [thread overview]
Message-ID: <160346039951.1406.11541356593709798889@emeril.freedesktop.org> (raw)
In-Reply-To: <20201023122811.2374118-1-daniel.vetter@ffwll.ch>
== Series Details ==
Series: series starting with [1/5] drm/radeon: Stop changing the drm_driver struct
URL : https://patchwork.freedesktop.org/series/82993/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
56ad54cc20b8 drm/radeon: Stop changing the drm_driver struct
-:60: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#60: FILE: drivers/gpu/drm/radeon/radeon_drv.c:587:
+ DRM_IOCTL_DEF_DRV(RADEON_CP_INIT, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:60: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#60: FILE: drivers/gpu/drm/radeon/radeon_drv.c:587:
+ DRM_IOCTL_DEF_DRV(RADEON_CP_INIT, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:61: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#61: FILE: drivers/gpu/drm/radeon/radeon_drv.c:588:
+ DRM_IOCTL_DEF_DRV(RADEON_CP_START, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:61: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#61: FILE: drivers/gpu/drm/radeon/radeon_drv.c:588:
+ DRM_IOCTL_DEF_DRV(RADEON_CP_START, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:62: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#62: FILE: drivers/gpu/drm/radeon/radeon_drv.c:589:
+ DRM_IOCTL_DEF_DRV(RADEON_CP_STOP, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:62: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#62: FILE: drivers/gpu/drm/radeon/radeon_drv.c:589:
+ DRM_IOCTL_DEF_DRV(RADEON_CP_STOP, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:63: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#63: FILE: drivers/gpu/drm/radeon/radeon_drv.c:590:
+ DRM_IOCTL_DEF_DRV(RADEON_CP_RESET, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:63: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#63: FILE: drivers/gpu/drm/radeon/radeon_drv.c:590:
+ DRM_IOCTL_DEF_DRV(RADEON_CP_RESET, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:74: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#74: FILE: drivers/gpu/drm/radeon/radeon_drv.c:601:
+ DRM_IOCTL_DEF_DRV(RADEON_INDIRECT, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:74: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#74: FILE: drivers/gpu/drm/radeon/radeon_drv.c:601:
+ DRM_IOCTL_DEF_DRV(RADEON_INDIRECT, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:81: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#81: FILE: drivers/gpu/drm/radeon/radeon_drv.c:608:
+ DRM_IOCTL_DEF_DRV(RADEON_INIT_HEAP, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:81: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#81: FILE: drivers/gpu/drm/radeon/radeon_drv.c:608:
+ DRM_IOCTL_DEF_DRV(RADEON_INIT_HEAP, drm_invalid_op, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
^
-:88: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#88: FILE: drivers/gpu/drm/radeon/radeon_drv.c:615:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_INFO, radeon_gem_info_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:89: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#89: FILE: drivers/gpu/drm/radeon/radeon_drv.c:616:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_CREATE, radeon_gem_create_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:90: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#90: FILE: drivers/gpu/drm/radeon/radeon_drv.c:617:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_MMAP, radeon_gem_mmap_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:91: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#91: FILE: drivers/gpu/drm/radeon/radeon_drv.c:618:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_SET_DOMAIN, radeon_gem_set_domain_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-:91: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#91: FILE: drivers/gpu/drm/radeon/radeon_drv.c:618:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_SET_DOMAIN, radeon_gem_set_domain_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:94: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#94: FILE: drivers/gpu/drm/radeon/radeon_drv.c:621:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_WAIT_IDLE, radeon_gem_wait_idle_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-:94: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#94: FILE: drivers/gpu/drm/radeon/radeon_drv.c:621:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_WAIT_IDLE, radeon_gem_wait_idle_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:95: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#95: FILE: drivers/gpu/drm/radeon/radeon_drv.c:622:
+ DRM_IOCTL_DEF_DRV(RADEON_CS, radeon_cs_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:96: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#96: FILE: drivers/gpu/drm/radeon/radeon_drv.c:623:
+ DRM_IOCTL_DEF_DRV(RADEON_INFO, radeon_info_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:97: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#97: FILE: drivers/gpu/drm/radeon/radeon_drv.c:624:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_SET_TILING, radeon_gem_set_tiling_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-:97: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#97: FILE: drivers/gpu/drm/radeon/radeon_drv.c:624:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_SET_TILING, radeon_gem_set_tiling_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:98: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#98: FILE: drivers/gpu/drm/radeon/radeon_drv.c:625:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_GET_TILING, radeon_gem_get_tiling_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
-:98: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#98: FILE: drivers/gpu/drm/radeon/radeon_drv.c:625:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_GET_TILING, radeon_gem_get_tiling_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:99: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#99: FILE: drivers/gpu/drm/radeon/radeon_drv.c:626:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_BUSY, radeon_gem_busy_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:100: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#100: FILE: drivers/gpu/drm/radeon/radeon_drv.c:627:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_VA, radeon_gem_va_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:101: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#101: FILE: drivers/gpu/drm/radeon/radeon_drv.c:628:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_OP, radeon_gem_op_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
-:102: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#102: FILE: drivers/gpu/drm/radeon/radeon_drv.c:629:
+ DRM_IOCTL_DEF_DRV(RADEON_GEM_USERPTR, radeon_gem_userptr_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
^
total: 0 errors, 4 warnings, 25 checks, 157 lines checked
4d5fcb372a4a drm: Compile out legacy chunks from struct drm_device
-:49: WARNING:BRACES: braces {} are not necessary for single statement blocks
#49: FILE: drivers/gpu/drm/drm_vblank.c:214:
+ else if (dev->driver->get_vblank_counter) {
return dev->driver->get_vblank_counter(dev, pipe);
}
-:63: WARNING:BRACES: braces {} are not necessary for single statement blocks
#63: FILE: drivers/gpu/drm/drm_vblank.c:437:
+ else {
dev->driver->disable_vblank(dev, pipe);
}
-:63: CHECK:BRACES: Unbalanced braces around else statement
#63: FILE: drivers/gpu/drm/drm_vblank.c:437:
+ else {
-:77: WARNING:BRACES: braces {} are not necessary for single statement blocks
#77: FILE: drivers/gpu/drm/drm_vblank.c:1107:
+ else if (dev->driver->enable_vblank) {
return dev->driver->enable_vblank(dev, pipe);
}
total: 0 errors, 3 warnings, 1 checks, 64 lines checked
e83b0c263080 drm/amdgpu: Paper over the drm_driver mangling for virt
6049eee13ae9 drm: Allow const struct drm_driver
-:37: CHECK:SPACING: No space is necessary after a cast
#37: FILE: drivers/gpu/drm/drm_drv.c:593:
+ dev->driver = (struct drm_driver *) driver;
total: 0 errors, 0 warnings, 1 checks, 80 lines checked
81dc6fc9de5a drm/<drivers>: Constify struct drm_driver
-:694: WARNING:OBSOLETE: drivers/gpu/drm/tiny/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
-:697: WARNING:OBSOLETE: drivers/gpu/drm/tiny/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
total: 0 errors, 2 warnings, 0 checks, 619 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-10-23 13:40 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 12:28 [PATCH 1/5] drm/radeon: Stop changing the drm_driver struct Daniel Vetter
2020-10-23 12:28 ` Daniel Vetter
2020-10-23 12:28 ` [Intel-gfx] " Daniel Vetter
2020-10-23 12:28 ` [PATCH 2/5] drm: Compile out legacy chunks from struct drm_device Daniel Vetter
2020-10-23 12:28 ` [Intel-gfx] " Daniel Vetter
2020-10-23 15:10 ` Maxime Ripard
2020-10-23 15:10 ` [Intel-gfx] " Maxime Ripard
2020-10-25 22:08 ` Sam Ravnborg
2020-10-25 22:08 ` [Intel-gfx] " Sam Ravnborg
2020-10-26 8:37 ` Thomas Zimmermann
2020-10-26 8:37 ` [Intel-gfx] " Thomas Zimmermann
2020-10-26 9:17 ` Daniel Vetter
2020-10-26 9:17 ` [Intel-gfx] " Daniel Vetter
2020-10-23 12:28 ` [PATCH 3/5] drm/amdgpu: Paper over the drm_driver mangling for virt Daniel Vetter
2020-10-23 12:28 ` [Intel-gfx] " Daniel Vetter
2020-10-23 12:28 ` [PATCH 4/5] drm: Allow const struct drm_driver Daniel Vetter
2020-10-23 12:28 ` [Intel-gfx] " Daniel Vetter
2020-10-23 15:11 ` Maxime Ripard
2020-10-23 15:11 ` [Intel-gfx] " Maxime Ripard
2020-10-25 21:44 ` Sam Ravnborg
2020-10-25 21:44 ` [Intel-gfx] " Sam Ravnborg
2020-10-26 8:40 ` Thomas Zimmermann
2020-10-26 8:40 ` [Intel-gfx] " Thomas Zimmermann
2020-10-23 12:28 ` [PATCH 5/5] drm/<drivers>: Constify " Daniel Vetter
2020-10-23 12:28 ` [Intel-gfx] " Daniel Vetter
2020-10-23 12:28 ` Daniel Vetter
2020-10-23 12:28 ` Daniel Vetter
2020-10-23 15:13 ` Maxime Ripard
2020-10-23 15:13 ` [Intel-gfx] " Maxime Ripard
2020-10-23 15:13 ` Maxime Ripard
2020-10-23 15:22 ` kernel test robot
2020-10-23 15:22 ` [Intel-gfx] " kernel test robot
2020-10-23 15:22 ` kernel test robot
2020-10-23 15:22 ` kernel test robot
2020-10-23 15:22 ` kernel test robot
[not found] ` <20201023122811.2374118-5-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2020-10-23 16:04 ` [PATCH] " Daniel Vetter
2020-10-23 16:04 ` [Intel-gfx] " Daniel Vetter
2020-10-23 16:04 ` Daniel Vetter
2020-10-23 16:04 ` Daniel Vetter
[not found] ` <20201023160444.2465340-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2020-10-25 22:23 ` Sam Ravnborg
2020-10-25 22:23 ` [Intel-gfx] " Sam Ravnborg
2020-10-25 22:23 ` Sam Ravnborg
2020-10-25 22:23 ` Sam Ravnborg
[not found] ` <20201025222303.GC13779-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2020-10-25 23:04 ` Daniel Vetter
2020-10-25 23:04 ` [Intel-gfx] " Daniel Vetter
2020-10-25 23:04 ` Daniel Vetter
2020-10-25 23:04 ` Daniel Vetter
2020-10-26 8:43 ` [PATCH 5/5] " Thomas Zimmermann
2020-10-26 8:43 ` [Intel-gfx] " Thomas Zimmermann
2020-10-26 8:43 ` Thomas Zimmermann
2020-10-26 8:43 ` Thomas Zimmermann
2020-10-26 9:14 ` Daniel Vetter
2020-10-26 9:14 ` [Intel-gfx] " Daniel Vetter
2020-10-26 9:14 ` Daniel Vetter
2020-10-26 9:14 ` Daniel Vetter
2020-10-23 13:39 ` Patchwork [this message]
2020-10-23 13:42 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/radeon: Stop changing the drm_driver struct Patchwork
2020-10-23 14:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-10-23 16:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/radeon: Stop changing the drm_driver struct (rev2) Patchwork
2020-10-23 16:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-10-23 16:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-10-23 17:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm/radeon: Stop changing the drm_driver struct Patchwork
2020-10-23 20:37 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/radeon: Stop changing the drm_driver struct (rev2) Patchwork
2020-10-30 10:11 [PATCH 1/5] drm/radeon: Stop changing the drm_driver struct Daniel Vetter
2020-10-30 10:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160346039951.1406.11541356593709798889@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.