From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Ewan D . Milne" <emilne@redhat.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Brian Bunker <brian@purestorage.com>
Subject: Re: [PATCH] scsi_dh_alua: avoid crash during alua_bus_detach()
Date: Mon, 2 Nov 2020 21:01:56 -0500 [thread overview]
Message-ID: <160436888615.27492.12981270573337953625.b4-ty@oracle.com> (raw)
In-Reply-To: <20200924104559.26753-1-hare@suse.de>
On Thu, 24 Sep 2020 12:45:59 +0200, Hannes Reinecke wrote:
> alua_bus_detach() might be running concurrently with alua_rtpg_work(),
> so we might trip over h->sdev == NULL and call BUG_ON().
> The correct way of handling it would be to not set h->sdev to NULL
> in alua_bus_detach(), and call rcu_synchronize() before the final
> delete to ensure that all concurrent threads have left the critical
> section.
> Then we can get rid of the BUG_ON(), and replace it with a simple
> if condition.
Applied to 5.10/scsi-fixes, thanks!
[1/1] scsi: scsi_dh_alua: Avoid crash during alua_bus_detach()
https://git.kernel.org/mkp/scsi/c/5faf50e9e9fd
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-11-03 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 10:45 [PATCH] scsi_dh_alua: avoid crash during alua_bus_detach() Hannes Reinecke
[not found] ` <2F7D7601-D9C2-4FFD-AA59-65A243F16AA9@purestorage.com>
2020-09-24 16:38 ` Brian Bunker
2020-09-26 22:01 ` Bart Van Assche
2020-09-28 21:02 ` Ewan D. Milne
2020-11-03 2:01 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160436888615.27492.12981270573337953625.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=brian@purestorage.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.