From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc
Date: Wed, 18 Nov 2020 17:04:30 +0000 [thread overview]
Message-ID: <160571907017.19853.2138891452982731448@build.alporthouse.com> (raw)
In-Reply-To: <20201118163601.958254-1-tvrtko.ursulin@linux.intel.com>
Quoting Tvrtko Ursulin (2020-11-18 16:36:01)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> There is this long standing nit of igt/tools/intel_error_decode asserting
> when you feed it an error state from a GPU the local libdrm does not know
> of.
>
> To fix this I need a tweak in drm_intel_decode_context_alloc to make it
> not assert but just return NULL (which seems an already possible return
> value).
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Good riddance,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-18 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 16:36 [PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc Tvrtko Ursulin
2020-11-18 17:04 ` Chris Wilson [this message]
2020-11-19 13:42 ` Tvrtko Ursulin
2020-11-19 13:52 ` Chris Wilson
2020-11-19 13:58 ` Tvrtko Ursulin
2021-06-17 9:20 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160571907017.19853.2138891452982731448@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.