From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Jordan Niethe <jniethe5@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: oohall@gmail.com, npiggin@gmail.com
Subject: Re: [PATCH v4 1/2] powerpc/64: Set up a kernel stack for secondaries before cpu_restore()
Date: Wed, 25 Nov 2020 22:57:48 +1100 (AEDT) [thread overview]
Message-ID: <160630539903.2174375.14042902720117238305.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20201014072837.24539-1-jniethe5@gmail.com>
On Wed, 14 Oct 2020 18:28:36 +1100, Jordan Niethe wrote:
> Currently in generic_secondary_smp_init(), cur_cpu_spec->cpu_restore()
> is called before a stack has been set up in r1. This was previously fine
> as the cpu_restore() functions were implemented in assembly and did not
> use a stack. However commit 5a61ef74f269 ("powerpc/64s: Support new
> device tree binding for discovering CPU features") used
> __restore_cpu_cpufeatures() as the cpu_restore() function for a
> device-tree features based cputable entry. This is a C function and
> hence uses a stack in r1.
>
> [...]
Applied to powerpc/next.
[1/2] powerpc/64: Set up a kernel stack for secondaries before cpu_restore()
https://git.kernel.org/powerpc/c/3c0b976bf20d236c57adcefa80f86a0a1d737727
[2/2] powerpc/64s: Convert some cpu_setup() and cpu_restore() functions to C
https://git.kernel.org/powerpc/c/344fbab991a568dc33ad90711b489d870e18d26d
cheers
prev parent reply other threads:[~2020-11-25 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 7:28 [PATCH v4 1/2] powerpc/64: Set up a kernel stack for secondaries before cpu_restore() Jordan Niethe
2020-10-14 7:28 ` [PATCH v4 2/2] powerpc/64s: Convert some cpu_setup() and cpu_restore() functions to C Jordan Niethe
2020-11-25 11:57 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160630539903.2174375.14042902720117238305.b4-ty@ellerman.id.au \
--to=patch-notifications@ellerman.id.au \
--cc=jniethe5@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.