From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Force a failed engine reset
Date: Tue, 12 Jan 2021 20:43:52 +0000 [thread overview]
Message-ID: <161048423285.9280.16741470438251455269@build.alporthouse.com> (raw)
In-Reply-To: <87pn2akrsu.fsf@gaia.fi.intel.com>
Quoting Mika Kuoppala (2021-01-12 17:07:13)
> > + if (count & 1) {
> > + err = intel_engine_reset(engine, NULL);
> > + if (err) {
> > + GEM_TRACE_ERR("intel_engine_reset(%s) failed, err:%d\n",
> > + engine->name, err);
> > + GEM_TRACE_DUMP();
> > + break;
> > + }
> > + } else {
> > + force_reset_timeout(engine);
> > + err = intel_engine_reset(engine, NULL);
>
> We dont promote to global here if the engine one fails?
>
> If not, what mechanism then guarantees the request completion.
We are testing that a failed engine reset (due to the request
preparation timing out) does not affect the status of inflight work.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-12 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 11:37 [Intel-gfx] [PATCH] drm/i915/selftests: Force a failed engine reset Chris Wilson
2021-01-12 12:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-01-12 12:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-12 16:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-12 17:07 ` [Intel-gfx] [PATCH] " Mika Kuoppala
2021-01-12 20:43 ` Chris Wilson [this message]
2021-01-13 16:31 [Intel-gfx] [CI 1/2] " Chris Wilson
2021-01-13 20:50 ` [Intel-gfx] [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161048423285.9280.16741470438251455269@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.