From: no-reply@patchew.org
To: zhanghan64@huawei.com
Cc: hunongda@huawei.com, zhang.zhanghailiang@huawei.com,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
alex.chen@huawei.com, kraxel@redhat.com, zhanghan64@huawei.com
Subject: Re: [PATCH v2 0/7]Fix some style problems in audio
Date: Thu, 14 Jan 2021 17:54:45 -0800 (PST) [thread overview]
Message-ID: <161067568385.26655.3608742083119578086@73fb1a5943b8> (raw)
In-Reply-To: <20210115012431.79533-1-zhanghan64@huawei.com>
Patchew URL: https://patchew.org/QEMU/20210115012431.79533-1-zhanghan64@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Subject: [PATCH v2 0/7]Fix some style problems in audio
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210115012431.79533-1-zhanghan64@huawei.com -> patchew/20210115012431.79533-1-zhanghan64@huawei.com
Switched to a new branch 'test'
aa9fd41 audio: space prohibited between function name and parenthesis'('
f36ebe9 audio: Suspect code indent for conditional statements
a5048b4 audio: Don't use '%#' in format strings
136df5d audio: Fix lines over 90 characters
5cfea16 audio: foo* bar" should be "foo *bar".
0f4324f audio: Add spaces around operator/delete redundant spaces
4a9b916 audio: Add braces for statements/fix braces' position
=== OUTPUT BEGIN ===
1/7 Checking commit 4a9b9160f3c9 (audio: Add braces for statements/fix braces' position)
2/7 Checking commit 0f4324ff6333 (audio: Add spaces around operator/delete redundant spaces)
ERROR: space prohibited between function name and open parenthesis '('
#23: FILE: audio/audio_template.h:211:
+ glue (audio_pcm_hw_free_resources_ , TYPE) (hw);
total: 1 errors, 0 warnings, 32 lines checked
Patch 2/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/7 Checking commit 5cfea163dd87 (audio: foo* bar" should be "foo *bar".)
4/7 Checking commit 136df5d76762 (audio: Fix lines over 90 characters)
5/7 Checking commit a5048b437dad (audio: Don't use '%#' in format strings)
6/7 Checking commit f36ebe97559f (audio: Suspect code indent for conditional statements)
7/7 Checking commit aa9fd41947b4 (audio: space prohibited between function name and parenthesis'(')
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210115012431.79533-1-zhanghan64@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2021-01-15 1:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 1:24 [PATCH v2 0/7]Fix some style problems in audio Zhang Han
2021-01-15 1:24 ` [PATCH v2 1/7] audio: Add braces for statements/fix braces' position Zhang Han
2021-01-15 1:24 ` [PATCH v2 2/7] audio: Add spaces around operator/delete redundant spaces Zhang Han
2021-01-15 9:21 ` Philippe Mathieu-Daudé
2021-01-15 1:24 ` [PATCH v2 3/7] audio: foo* bar" should be "foo *bar" Zhang Han
2021-01-15 1:24 ` [PATCH v2 4/7] audio: Fix lines over 90 characters Zhang Han
2021-01-15 1:24 ` [PATCH v2 5/7] audio: Don't use '%#' in format strings Zhang Han
2021-01-15 9:20 ` Philippe Mathieu-Daudé
2021-01-15 1:24 ` [PATCH v2 6/7] audio: Suspect code indent for conditional statements Zhang Han
2021-01-15 1:24 ` [PATCH v2 7/7] audio: space prohibited between function name and parenthesis'(' Zhang Han
2021-01-15 1:54 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161067568385.26655.3608742083119578086@73fb1a5943b8 \
--to=no-reply@patchew.org \
--cc=alex.chen@huawei.com \
--cc=hunongda@huawei.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhanghan64@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.