From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
edumazet@google.com, syzkaller@googlegroups.com
Subject: Re: [PATCH net] net_sched: avoid shift-out-of-bounds in tcindex_set_parms()
Date: Sat, 16 Jan 2021 02:20:08 +0000 [thread overview]
Message-ID: <161076360856.6674.16961085253289564188.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210114185229.1742255-1-eric.dumazet@gmail.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 14 Jan 2021 10:52:29 -0800 you wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> tc_index being 16bit wide, we need to check that TCA_TCINDEX_SHIFT
> attribute is not silly.
>
> UBSAN: shift-out-of-bounds in net/sched/cls_tcindex.c:260:29
> shift exponent 255 is too large for 32-bit type 'int'
> CPU: 0 PID: 8516 Comm: syz-executor228 Not tainted 5.10.0-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> Call Trace:
> __dump_stack lib/dump_stack.c:79 [inline]
> dump_stack+0x107/0x163 lib/dump_stack.c:120
> ubsan_epilogue+0xb/0x5a lib/ubsan.c:148
> __ubsan_handle_shift_out_of_bounds.cold+0xb1/0x181 lib/ubsan.c:395
> valid_perfect_hash net/sched/cls_tcindex.c:260 [inline]
> tcindex_set_parms.cold+0x1b/0x215 net/sched/cls_tcindex.c:425
> tcindex_change+0x232/0x340 net/sched/cls_tcindex.c:546
> tc_new_tfilter+0x13fb/0x21b0 net/sched/cls_api.c:2127
> rtnetlink_rcv_msg+0x8b6/0xb80 net/core/rtnetlink.c:5555
> netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2494
> netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
> netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
> netlink_sendmsg+0x907/0xe40 net/netlink/af_netlink.c:1919
> sock_sendmsg_nosec net/socket.c:652 [inline]
> sock_sendmsg+0xcf/0x120 net/socket.c:672
> ____sys_sendmsg+0x6e8/0x810 net/socket.c:2336
> ___sys_sendmsg+0xf3/0x170 net/socket.c:2390
> __sys_sendmsg+0xe5/0x1b0 net/socket.c:2423
> do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> [...]
Here is the summary with links:
- [net] net_sched: avoid shift-out-of-bounds in tcindex_set_parms()
https://git.kernel.org/netdev/net/c/bcd0cf19ef82
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-01-16 2:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 18:52 [PATCH net] net_sched: avoid shift-out-of-bounds in tcindex_set_parms() Eric Dumazet
2021-01-16 2:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161076360856.6674.16961085253289564188.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.