From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Restrict DRM_I915_DEBUG to developer builds
Date: Fri, 22 Jan 2021 09:39:08 +0000 [thread overview]
Message-ID: <161130834876.28599.11979482696006821769@build.alporthouse.com> (raw)
In-Reply-To: <874kj9l3f5.fsf@intel.com>
Quoting Jani Nikula (2021-01-22 09:35:42)
> On Fri, 22 Jan 2021, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Let's not encourage everybody to build i915's debug code, and certainly
> > not the build robots who need to scrutinise the production build. Since
> > CI will complain if the debug build is broken, having the other build
> > bots focus on the builds we don't cover ourselves should improve the
> > build coverage.
>
> I don't disagree with this, although I wrote in another mail that I'm
> not sure DRM_I915_DEBUG should select DRM_I915_WERROR. I think they
> should be two separate things.
DRM_I915_DEBUG is the CI catch-all, and so the build we recommend
developers try at least once. But the original purpose of DRM_I915_DEBUG
was to be able to switch on features for CI without having to bug Tomi.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-22 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 9:10 [Intel-gfx] [PATCH] drm/i915: Restrict DRM_I915_DEBUG to developer builds Chris Wilson
2021-01-22 9:35 ` Jani Nikula
2021-01-22 9:39 ` Chris Wilson [this message]
2021-01-22 9:43 ` Jani Nikula
2021-01-22 15:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161130834876.28599.11979482696006821769@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.