From: no-reply@patchew.org
To: isaku.yamahata@gmail.com
Cc: isaku.yamahata@intel.com, imammedo@redhat.com,
qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [PATCH 0/4] ACPI related fixes
Date: Thu, 4 Feb 2021 00:15:44 -0800 (PST) [thread overview]
Message-ID: <161242654373.30579.11329990738781122576@c667a6b167f6> (raw)
In-Reply-To: <cover.1612424814.git.isaku.yamahata@intel.com>
Patchew URL: https://patchew.org/QEMU/cover.1612424814.git.isaku.yamahata@intel.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: cover.1612424814.git.isaku.yamahata@intel.com
Subject: [PATCH 0/4] ACPI related fixes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/cover.1612424814.git.isaku.yamahata@intel.com -> patchew/cover.1612424814.git.isaku.yamahata@intel.com
Switched to a new branch 'test'
8eea4e1 i386: acpi: Don't build HPET ACPI entry if HPET is disabled
4f0ab1b hw/i386: declare ACPI mother board resource for MMCONFIG region
6947812 acpi: set fadt.smi_cmd to zero when SMM is not supported
4ae92fd acpi/core: always set SCI_EN when SMM isn't supported
=== OUTPUT BEGIN ===
1/4 Checking commit 4ae92fd8e8a5 (acpi/core: always set SCI_EN when SMM isn't supported)
2/4 Checking commit 6947812c8e69 (acpi: set fadt.smi_cmd to zero when SMM is not supported)
ERROR: line over 90 characters
#41: FILE: hw/i386/acpi-build.c:167:
+ smm_enabled ? object_property_get_uint(o, ACPI_PM_PROP_ACPI_ENABLE_CMD, NULL) : 0,
ERROR: line over 90 characters
#44: FILE: hw/i386/acpi-build.c:169:
+ smm_enabled ? object_property_get_uint(o, ACPI_PM_PROP_ACPI_DISABLE_CMD, NULL) : 0,
total: 2 errors, 0 warnings, 23 lines checked
Patch 2/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/4 Checking commit 4f0ab1b9744c (hw/i386: declare ACPI mother board resource for MMCONFIG region)
4/4 Checking commit 8eea4e187ac8 (i386: acpi: Don't build HPET ACPI entry if HPET is disabled)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/cover.1612424814.git.isaku.yamahata@intel.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2021-02-04 8:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:04 [PATCH 0/4] ACPI related fixes isaku.yamahata
2021-02-04 8:04 ` [PATCH 1/4] acpi/core: always set SCI_EN when SMM isn't supported isaku.yamahata
2021-02-04 8:04 ` [PATCH 2/4] acpi: set fadt.smi_cmd to zero when SMM is not supported isaku.yamahata
2021-02-04 8:04 ` [PATCH 3/4] hw/i386: declare ACPI mother board resource for MMCONFIG region isaku.yamahata
2021-02-04 8:04 ` [PATCH 4/4] i386: acpi: Don't build HPET ACPI entry if HPET is disabled isaku.yamahata
2021-02-04 8:56 ` Philippe Mathieu-Daudé
2021-02-04 8:15 ` no-reply [this message]
2021-02-05 13:48 ` [PATCH 0/4] ACPI related fixes Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161242654373.30579.11329990738781122576@c667a6b167f6 \
--to=no-reply@patchew.org \
--cc=imammedo@redhat.com \
--cc=isaku.yamahata@gmail.com \
--cc=isaku.yamahata@intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.