From: Stephen Boyd <swboyd@chromium.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH v4 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver
Date: Sat, 06 Feb 2021 19:21:39 -0800 [thread overview]
Message-ID: <161266809977.76967.12637197400196121672@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210206161711.6f555434@archlinux>
Quoting Jonathan Cameron (2021-02-06 08:17:11)
> On Tue, 2 Feb 2021 10:44:34 -0800
> Stephen Boyd <swboyd@chromium.org> wrote:
>
> > +static struct platform_driver cros_ec_mkbp_proximity_driver = {
> > + .driver = {
> > + .name = "cros-ec-mkbp-proximity",
> > + .of_match_table = of_match_ptr(cros_ec_mkbp_proximity_of_match),
> I'm going to assume we know no one is going to use this with
> ACPI via PRP0001 given presumably the firmware on these devices
> is tightly controlled.
Correct.
>
> However, we should should still drop the of_match_ptr
> as it will lead to an unused warning for cros_ec_mkbp_proximity_of_match
> if anyone builds this without CONFIG_OF + it sets a general bad
> precedence that I'd rather wasn't around for people to copy.
> Note that in general we are slowly ripping these out of IIO but
> probably lots still there.
>
> If this is all that is needed in this version I'll just do it
> whilst applying unless anyone shouts.
>
Agreed. Thanks for fixing that last little bit.
next prev parent reply other threads:[~2021-02-07 3:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 18:44 [PATCHv4 0/3] iio: Add a ChromeOS EC MKBP proximity driver Stephen Boyd
2021-02-02 18:44 ` [PATCH v4 1/3] platform/chrome: cros_ec: Add SW_FRONT_PROXIMITY MKBP define Stephen Boyd
2021-02-02 18:44 ` [PATCH v4 2/3] dt-bindings: iio: Add cros ec proximity yaml doc Stephen Boyd
2021-02-03 8:29 ` Enric Balletbo Serra
2021-02-09 21:13 ` Rob Herring
2021-02-10 2:40 ` Stephen Boyd
2021-02-02 18:44 ` [PATCH v4 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver Stephen Boyd
2021-02-06 16:17 ` Jonathan Cameron
2021-02-07 3:21 ` Stephen Boyd [this message]
2021-02-10 2:40 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161266809977.76967.12637197400196121672@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.