From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Disallow plane x+w>stride on ilk+ with X-tiling
Date: Tue, 09 Feb 2021 09:50:28 +0000 [thread overview]
Message-ID: <161286422853.7943.29461918361584777@build.alporthouse.com> (raw)
In-Reply-To: <161286252973.7943.3574089157194446990@build.alporthouse.com>
Quoting Chris Wilson (2021-02-09 09:22:09)
> Quoting Ville Syrjala (2021-02-09 02:19:16)
> > + while ((src_x + src_w) * cpp > plane_state->color_plane[0].stride) {
> > + if (offset == 0) {
> > + drm_dbg_kms(&dev_priv->drm,
> > + "Unable to find suitable display surface offset due to X-tiling\n");
> > + return -EINVAL;
> > + }
> > +
> > + offset = intel_plane_adjust_aligned_offset(&src_x, &src_y, plane_state, 0,
> > + offset, offset - alignment);
> The reason for choosing a nearby tile offset was to reduce src_x/src_y
> to fit within the crtc limits. While remapping could be used to solve
> that, the aligned_offset computation allows reuse of a single view.
Should there not be a second constraint on the loop to make sure src_x +
src_w is less than 4095/8191/etc?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-09 9:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 2:19 [Intel-gfx] [PATCH 1/3] drm/i915: Disallow plane x+w>stride on ilk+ with X-tiling Ville Syrjala
2021-02-09 2:19 ` [PATCH 2/3] drm/i915: Fix overlay frontbuffer tracking Ville Syrjala
2021-02-09 2:19 ` [Intel-gfx] " Ville Syrjala
2021-02-09 9:33 ` Chris Wilson
2021-02-09 9:33 ` [Intel-gfx] " Chris Wilson
2021-02-09 2:19 ` [Intel-gfx] [PATCH 3/3] drm/i915: Warn when releasing a frontbuffer while in use Ville Syrjala
2021-02-09 9:39 ` Chris Wilson
2021-02-09 2:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Disallow plane x+w>stride on ilk+ with X-tiling Patchwork
2021-02-09 3:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-02-09 15:09 ` Ville Syrjälä
2021-02-09 9:22 ` [Intel-gfx] [PATCH 1/3] " Chris Wilson
2021-02-09 9:50 ` Chris Wilson [this message]
2021-02-09 14:44 ` Ville Syrjälä
2021-02-09 14:51 ` Ville Syrjälä
2021-02-09 15:21 ` Ville Syrjälä
2021-02-10 12:05 ` Juha-Pekka Heikkila
2021-02-09 17:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
2021-02-09 21:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161286422853.7943.29461918361584777@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.