From: "irqchip-bot for Greg Kroah-Hartman" <tip-bot2@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Michael Walle <michael@walle.cc>, Marc Zyngier <maz@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
stable <stable@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
tglx@linutronix.de
Subject: [irqchip: irq/irqchip-next] debugfs: do not attempt to create a new file before the filesystem is initalized
Date: Thu, 18 Feb 2021 11:43:24 -0000 [thread overview]
Message-ID: <161364860439.20312.9107550617720513848.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210218100818.3622317-2-gregkh@linuxfoundation.org>
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: fb0757f54bc9259c4c67907fd97ca3ad109d3f6f
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/fb0757f54bc9259c4c67907fd97ca3ad109d3f6f
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
AuthorDate: Thu, 18 Feb 2021 11:08:18 +01:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Thu, 18 Feb 2021 11:39:18
debugfs: do not attempt to create a new file before the filesystem is initalized
Some subsystems want to add debugfs files at early boot, way before
debugfs is initialized. This seems to work somehow as the vfs layer
will not allow it to happen, but let's be explicit and test to ensure we
are properly up and running before allowing files to be created.
Reported-by: Michael Walle <michael@walle.cc>
Reported-by: Marc Zyngier <maz@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210218100818.3622317-2-gregkh@linuxfoundation.org
---
fs/debugfs/inode.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index bbeb563..86c7f04 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -318,6 +318,9 @@ static struct dentry *start_creating(const char *name, struct dentry *parent)
if (!(debugfs_allow & DEBUGFS_ALLOW_API))
return ERR_PTR(-EPERM);
+ if (!debugfs_initialized())
+ return ERR_PTR(-ENOENT);
+
pr_debug("creating file '%s'\n", name);
if (IS_ERR(parent))
next prev parent reply other threads:[~2021-02-18 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 10:08 [PATCH 1/2] debugfs: be more robust at handling improper input in debugfs_lookup() Greg Kroah-Hartman
2021-02-18 10:08 ` [PATCH 2/2] debugfs: do not attempt to create a new file before the filesystem is initalized Greg Kroah-Hartman
2021-02-18 11:43 ` irqchip-bot for Greg Kroah-Hartman [this message]
2021-02-18 11:43 ` [irqchip: irq/irqchip-next] debugfs: be more robust at handling improper input in debugfs_lookup() irqchip-bot for Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161364860439.20312.9107550617720513848.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michael@walle.cc \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.