Re: [PATCH v21 00/17] i386 cleanup PART 2 - no-reply

From: no-reply@patchew.org
To: cfontana@suse.de
Cc: lvivier@redhat.com, peter.maydell@linaro.org, thuth@redhat.com,
	ehabkost@redhat.com, philmd@redhat.com,
	richard.henderson@linaro.org, qemu-devel@nongnu.org,
	r.bolshakov@yadro.com, cfontana@suse.de, pbonzini@redhat.com,
	alex.bennee@linaro.org
Subject: Re: [PATCH v21 00/17] i386 cleanup PART 2
Date: Mon, 22 Feb 2021 06:00:56 -0800 (PST)	[thread overview]
Message-ID: <161400245485.1050.14191792112251905606@c667a6b167f6> (raw)
In-Reply-To: <20210222133634.2235-1-cfontana@suse.de>

Patchew URL: https://patchew.org/QEMU/20210222133634.2235-1-cfontana@suse.de/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210222133634.2235-1-cfontana@suse.de
Subject: [PATCH v21 00/17] i386 cleanup PART 2

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210221174510.22542-1-alxndr@bu.edu -> patchew/20210221174510.22542-1-alxndr@bu.edu
 - [tag update]      patchew/20210221215915.2568943-1-f4bug@amsat.org -> patchew/20210221215915.2568943-1-f4bug@amsat.org
 * [new tag]         patchew/20210222133634.2235-1-cfontana@suse.de -> patchew/20210222133634.2235-1-cfontana@suse.de
Switched to a new branch 'test'
51fd723 i386: move cpu_load_efer into SOFTMMU-only section of cpu.h
7e0106d i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU
c32da01 i386: split off softmmu part of cpu.c
ce0a27b i386: split seg_helper into user-only and softmmu parts
0a87bcd i386: split svm_helper into softmmu and stub-only user
ded6ff8 i386: separate fpu_helper into user and softmmu parts
05e50f8 i386: split misc helper into user and softmmu parts
4b06271 i386: move TCG btp_helper into softmmu/
c40fc6d i386: split tcg excp_helper into softmmu and user parts
cc1d27c i386: split smm helper (softmmu)
e68d149 i386: split off softmmu-only functionality in tcg-cpu
7e01522 meson: add target_user_arch
3cdba09 accel-cpu: make cpu_realizefn return a bool
0a9f608 target/i386: fix host_cpu_adjust_phys_bits error handling
0c0b641 accel: introduce new accessor functions
c042760 cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn
b3ee5c0 i386: split cpu accelerators from cpu.c, using AccelCPUClass

=== OUTPUT BEGIN ===
1/17 Checking commit b3ee5c087574 (i386: split cpu accelerators from cpu.c, using AccelCPUClass)
WARNING: line over 80 characters
#1336: FILE: target/i386/tcg/tcg-cpu.c:125:
+    memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0);

total: 0 errors, 1 warnings, 1256 lines checked

Patch 1/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/17 Checking commit c0427607265d (cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn)
3/17 Checking commit 0c0b641218ef (accel: introduce new accessor functions)
4/17 Checking commit 0a9f608c8298 (target/i386: fix host_cpu_adjust_phys_bits error handling)
5/17 Checking commit 3cdba091d903 (accel-cpu: make cpu_realizefn return a bool)
6/17 Checking commit 7e01522869da (meson: add target_user_arch)
7/17 Checking commit e68d1493e9b8 (i386: split off softmmu-only functionality in tcg-cpu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

WARNING: line over 80 characters
#115: FILE: target/i386/tcg/softmmu/tcg-cpu.c:72:
+    memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0);

total: 0 errors, 2 warnings, 212 lines checked

Patch 7/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/17 Checking commit cc1d27c231e5 (i386: split smm helper (softmmu))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
 target/i386/tcg/{ => softmmu}/smm_helper.c | 19 ++-----------------

total: 0 errors, 1 warnings, 84 lines checked

Patch 8/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/17 Checking commit c40fc6d27c9b (i386: split tcg excp_helper into softmmu and user parts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#598: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#736: FILE: target/i386/tcg/softmmu/excp_helper.c:134:
+            /* Bits 20-13 provide bits 39-32 of the address, bit 21 is reserved.

WARNING: Block comments use a leading /* on a separate line
#810: FILE: target/i386/tcg/softmmu/excp_helper.c:208:
+/* return value:

WARNING: line over 80 characters
#911: FILE: target/i386/tcg/softmmu/excp_helper.c:309:
+            pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff) << 3)) &

WARNING: Block comments use a leading /* on a separate line
#1005: FILE: target/i386/tcg/softmmu/excp_helper.c:403:
+            /* Bits 20-13 provide bits 39-32 of the address, bit 21 is reserved.

WARNING: Block comments use a leading /* on a separate line
#1100: FILE: target/i386/tcg/softmmu/excp_helper.c:498:
+        /* only set write access if already dirty... otherwise wait

WARNING: Block comments use * on subsequent lines
#1101: FILE: target/i386/tcg/softmmu/excp_helper.c:499:
+        /* only set write access if already dirty... otherwise wait
+           for dirty access */

WARNING: Block comments use a trailing */ on a separate line
#1101: FILE: target/i386/tcg/softmmu/excp_helper.c:499:
+           for dirty access */

WARNING: Block comments use a leading /* on a separate line
#1114: FILE: target/i386/tcg/softmmu/excp_helper.c:512:
+    /* Even if 4MB pages, we map only one 4KB page in the cache to

WARNING: Block comments use * on subsequent lines
#1115: FILE: target/i386/tcg/softmmu/excp_helper.c:513:
+    /* Even if 4MB pages, we map only one 4KB page in the cache to
+       avoid filling it too fast */

WARNING: Block comments use a trailing */ on a separate line
#1115: FILE: target/i386/tcg/softmmu/excp_helper.c:513:
+       avoid filling it too fast */

ERROR: braces {} are necessary for all arms of this statement
#1129: FILE: target/i386/tcg/softmmu/excp_helper.c:527:
+    if (is_user)
[...]

total: 1 errors, 11 warnings, 612 lines checked

Patch 9/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/17 Checking commit 4b062716b3db (i386: move TCG btp_helper into softmmu/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#363: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#499: FILE: target/i386/tcg/softmmu/bpt_helper.c:132:
+    /* If nothing is changing except the global/local enable bits,

WARNING: Block comments use * on subsequent lines
#500: FILE: target/i386/tcg/softmmu/bpt_helper.c:133:
+    /* If nothing is changing except the global/local enable bits,
+       then we can make the change more efficient.  */

WARNING: Block comments use a trailing */ on a separate line
#500: FILE: target/i386/tcg/softmmu/bpt_helper.c:133:
+       then we can make the change more efficient.  */

WARNING: Block comments use a leading /* on a separate line
#502: FILE: target/i386/tcg/softmmu/bpt_helper.c:135:
+        /* Fold the global and local enable bits together into the

WARNING: Block comments use * on subsequent lines
#503: FILE: target/i386/tcg/softmmu/bpt_helper.c:136:
+        /* Fold the global and local enable bits together into the
+           global fields, then xor to show which registers have

WARNING: Block comments use a trailing */ on a separate line
#504: FILE: target/i386/tcg/softmmu/bpt_helper.c:137:
+           changed collective enable state.  */

total: 0 errors, 7 warnings, 623 lines checked

Patch 10/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit 05e50f803914 (i386: split misc helper into user and softmmu parts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#526: 
new file mode 100644

ERROR: switch and case should be at the same indent
#819: FILE: target/i386/tcg/softmmu/misc_helper.c:289:
+    switch ((uint32_t)env->regs[R_ECX]) {
[...]
+     case MSR_IA32_UCODE_REV:

total: 1 errors, 1 warnings, 1009 lines checked

Patch 11/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/17 Checking commit ded6ff8fd3bd (i386: separate fpu_helper into user and softmmu parts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#143: 
new file mode 100644

total: 0 errors, 1 warnings, 219 lines checked

Patch 12/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/17 Checking commit 0a87bcd74723 (i386: split svm_helper into softmmu and stub-only user)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
 target/i386/tcg/{ => softmmu}/svm_helper.c | 62 +-----------------------

total: 0 errors, 1 warnings, 169 lines checked

Patch 13/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/17 Checking commit ce0a27ba8af7 (i386: split seg_helper into user-only and softmmu parts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#320: 
new file mode 100644

ERROR: do not use C99 // comments
#347: FILE: target/i386/tcg/seg_helper.h:23:
+//#define DEBUG_PCALL

WARNING: Block comments use a leading /* on a separate line
#620: FILE: target/i386/tcg/user/seg_helper.c:73:
+    /* Since we emulate only user space, we cannot do more than

WARNING: Block comments use * on subsequent lines
#621: FILE: target/i386/tcg/user/seg_helper.c:74:
+    /* Since we emulate only user space, we cannot do more than
+       exiting the emulation with the suitable exception and error

WARNING: Block comments use a trailing */ on a separate line
#622: FILE: target/i386/tcg/user/seg_helper.c:75:
+       code. So update EIP for INT 0x80 and EXCP_SYSCALL. */

WARNING: Block comments use a leading /* on a separate line
#633: FILE: target/i386/tcg/user/seg_helper.c:86:
+    /* if user mode only, we simulate a fake exception

WARNING: Block comments use * on subsequent lines
#634: FILE: target/i386/tcg/user/seg_helper.c:87:
+    /* if user mode only, we simulate a fake exception
+       which will be handled outside the cpu execution

WARNING: Block comments use a trailing */ on a separate line
#635: FILE: target/i386/tcg/user/seg_helper.c:88:
+       loop */

total: 1 errors, 7 warnings, 595 lines checked

Patch 14/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/17 Checking commit c32da016e8de (i386: split off softmmu part of cpu.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#51: FILE: target/i386/cpu-internal.h:30:
+    /* feature flags names are taken from "Intel Processor Identification and

WARNING: Block comments use a leading /* on a separate line
#134: FILE: target/i386/cpu-softmmu.c:37:
+/* Return a QDict containing keys for all properties that can be included

WARNING: Block comments use a leading /* on a separate line
#187: FILE: target/i386/cpu-softmmu.c:90:
+/* Convert CPU model data from X86CPU object to a property dictionary

WARNING: Block comments use a leading /* on a separate line
#201: FILE: target/i386/cpu-softmmu.c:104:
+/* Convert CPU model data from X86CPU object to a property dictionary

WARNING: Block comments use a leading /* on a separate line
#217: FILE: target/i386/cpu-softmmu.c:120:
+        /* "hotplugged" is the only property that is configurable

WARNING: Block comments use a leading /* on a separate line
#307: FILE: target/i386/cpu-softmmu.c:210:
+        /* As we don't return every single property, full expansion needs

total: 0 errors, 7 warnings, 895 lines checked

Patch 15/17 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/17 Checking commit 7e0106d79b9d (i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU)
17/17 Checking commit 51fd723e1573 (i386: move cpu_load_efer into SOFTMMU-only section of cpu.h)
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20210222133634.2235-1-cfontana@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com