From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 08/11] xfs: force inode inactivation and retry fs writes when there isn't space
Date: Wed, 10 Mar 2021 19:06:25 -0800 [thread overview]
Message-ID: <161543198495.1947934.14544893595452477454.stgit@magnolia> (raw)
In-Reply-To: <161543194009.1947934.9910987247994410125.stgit@magnolia>
From: Darrick J. Wong <djwong@kernel.org>
Any time we try to modify a file's contents and it fails due to ENOSPC
or EDQUOT, force inode inactivation work to try to free space. We're
going to use the xfs_inodegc_free_space function externally in the next
patch, so add it to xfs_icache.h now to reduce churn.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
fs/xfs/xfs_icache.c | 10 ++++++++--
fs/xfs/xfs_icache.h | 1 +
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index 6081bba3c6ce..594d340bbe37 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -1868,10 +1868,16 @@ xfs_blockgc_free_space(
struct xfs_mount *mp,
struct xfs_eofblocks *eofb)
{
+ int error;
+
trace_xfs_blockgc_free_space(mp, eofb, _RET_IP_);
- return xfs_inode_walk(mp, 0, xfs_blockgc_scan_inode, eofb,
+ error = xfs_inode_walk(mp, 0, xfs_blockgc_scan_inode, eofb,
XFS_ICI_BLOCKGC_TAG);
+ if (error)
+ return error;
+
+ return xfs_inodegc_free_space(mp, eofb);
}
/*
@@ -2054,7 +2060,7 @@ xfs_inactive_inode(
* corrupted, we still need to clear the INACTIVE iflag so that we can move
* on to reclaiming the inode.
*/
-static int
+int
xfs_inodegc_free_space(
struct xfs_mount *mp,
struct xfs_eofblocks *eofb)
diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
index c199b920722a..9d5a1f4c0369 100644
--- a/fs/xfs/xfs_icache.h
+++ b/fs/xfs/xfs_icache.h
@@ -86,5 +86,6 @@ void xfs_inodegc_worker(struct work_struct *work);
void xfs_inodegc_force(struct xfs_mount *mp);
void xfs_inodegc_stop(struct xfs_mount *mp);
void xfs_inodegc_start(struct xfs_mount *mp);
+int xfs_inodegc_free_space(struct xfs_mount *mp, struct xfs_eofblocks *eofb);
#endif
next prev parent reply other threads:[~2021-03-11 3:07 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 3:05 [PATCHSET v3 00/11] xfs: deferred inode inactivation Darrick J. Wong
2021-03-11 3:05 ` [PATCH 01/11] xfs: prevent metadata files from being inactivated Darrick J. Wong
2021-03-11 13:05 ` Christoph Hellwig
2021-03-22 23:13 ` Dave Chinner
2021-03-11 3:05 ` [PATCH 02/11] xfs: refactor the predicate part of xfs_free_eofblocks Darrick J. Wong
2021-03-11 13:09 ` Christoph Hellwig
2021-03-15 18:46 ` Christoph Hellwig
2021-03-18 4:33 ` Darrick J. Wong
2021-03-19 1:48 ` Darrick J. Wong
2021-03-11 3:05 ` [PATCH 03/11] xfs: don't reclaim dquots with incore reservations Darrick J. Wong
2021-03-15 18:29 ` Christoph Hellwig
2021-03-22 23:31 ` Dave Chinner
2021-03-23 0:01 ` Darrick J. Wong
2021-03-23 1:48 ` Dave Chinner
2021-03-11 3:06 ` [PATCH 04/11] xfs: decide if inode needs inactivation Darrick J. Wong
2021-03-15 18:47 ` Christoph Hellwig
2021-03-15 19:06 ` Darrick J. Wong
2021-03-11 3:06 ` [PATCH 05/11] xfs: rename the blockgc workqueue Darrick J. Wong
2021-03-15 18:49 ` Christoph Hellwig
2021-03-11 3:06 ` [PATCH 06/11] xfs: deferred inode inactivation Darrick J. Wong
2021-03-16 7:27 ` Christoph Hellwig
2021-03-16 15:47 ` Darrick J. Wong
2021-03-17 15:21 ` Christoph Hellwig
2021-03-17 15:49 ` Darrick J. Wong
2021-03-22 23:46 ` Dave Chinner
2021-03-22 23:37 ` Dave Chinner
2021-03-23 0:24 ` Darrick J. Wong
2021-03-23 1:44 ` Dave Chinner
2021-03-23 4:00 ` Darrick J. Wong
2021-03-23 5:19 ` Dave Chinner
2021-03-24 2:04 ` Darrick J. Wong
2021-03-24 4:57 ` Dave Chinner
2021-03-25 4:20 ` Darrick J. Wong
2021-03-24 17:53 ` Christoph Hellwig
2021-03-25 4:26 ` Darrick J. Wong
2021-03-11 3:06 ` [PATCH 07/11] xfs: expose sysfs knob to control inode inactivation delay Darrick J. Wong
2021-03-11 3:06 ` Darrick J. Wong [this message]
2021-03-15 18:54 ` [PATCH 08/11] xfs: force inode inactivation and retry fs writes when there isn't space Christoph Hellwig
2021-03-15 19:06 ` Darrick J. Wong
2021-03-11 3:06 ` [PATCH 09/11] xfs: force inode garbage collection before fallocate when space is low Darrick J. Wong
2021-03-11 3:06 ` [PATCH 10/11] xfs: parallelize inode inactivation Darrick J. Wong
2021-03-15 18:55 ` Christoph Hellwig
2021-03-15 19:03 ` Darrick J. Wong
2021-03-23 22:21 ` Dave Chinner
2021-03-24 3:52 ` Darrick J. Wong
2021-03-11 3:06 ` [PATCH 11/11] xfs: create a polled function to force " Darrick J. Wong
2021-03-23 22:31 ` Dave Chinner
2021-03-24 3:34 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161543198495.1947934.14544893595452477454.stgit@magnolia \
--to=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.