From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-scsi@vger.kernel.org, jejb@linux.ibm.com,
sathya.prakash@broadcom.com,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
suganath-prabu.subramani@broadcom.com,
sreekanth.reddy@broadcom.com
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
MPT-FusionLinux.pdl@broadcom.com
Subject: Re: [PATCH] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context
Date: Thu, 18 Mar 2021 23:45:54 -0400 [thread overview]
Message-ID: <161612550237.18396.1025206016482733392.b4-ty@oracle.com> (raw)
In-Reply-To: <20210220093951.905362-1-christophe.jaillet@wanadoo.fr>
On Sat, 20 Feb 2021 10:39:51 +0100, Christophe JAILLET wrote:
> 'mpt3sas_get_port_by_id()' can be called when a spinlock is hold. So use
> GFP_ATOMIC instead of GFP_KERNEL when allocating memory.
>
> Issue spotted by call_kern.cocci:
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 7125 inside lock on line 7123 but uses GFP_KERNEL
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 6842 inside lock on line 6839 but uses GFP_KERNEL
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 6854 inside lock on line 6851 but uses GFP_KERNEL
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 7706 inside lock on line 7702 but uses GFP_KERNEL
> ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 10260 inside lock on line 10256 but uses GFP_KERNEL
Applied to 5.12/scsi-fixes, thanks!
[1/1] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context
https://git.kernel.org/mkp/scsi/c/a50bd6461690
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-03-19 3:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 9:39 [PATCH] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context Christophe JAILLET
2021-03-19 3:45 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161612550237.18396.1025206016482733392.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.