Re: [PATCH 6/6] firmware: qcom_scm: Only compile legacy calls on ARM

From: Stephen Boyd <swboyd@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Elliot Berman <eberman@codeaurora.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Brian Masney <masneyb@onstation.org>,
	Stephan Gerhold <stephan@gerhold.net>,
	Jeffrey Hugo <jhugo@codeaurora.org>,
	Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 6/6] firmware: qcom_scm: Only compile legacy calls on ARM
Date: Mon, 22 Mar 2021 20:36:19 -0700	[thread overview]
Message-ID: <161647057967.3012082.16471020030801311825@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <YEUQlY4X1e2PO8tl@builder.lan>

Quoting Bjorn Andersson (2021-03-07 09:42:45)
> On Sat 06 Mar 00:18 CST 2021, Stephen Boyd wrote:
> 
> > Quoting Elliot Berman (2021-03-05 10:18:09)
> > > On 3/3/2021 10:14 PM, Stephen Boyd wrote:
> > > > Quoting Elliot Berman (2021-03-03 19:35:08)
> > > 
> > >  > +    desc.args[0] = flags;
> > >  > +    desc.args[1] = virt_to_phys(entry);
> > >  > +
> > >  > +    return scm_legacy_call_atomic(NULL, &desc, NULL);
> > >  > +}
> > >  > +EXPORT_SYMBOL(qcom_scm_set_cold_boot_addr);
> > > 
> > > This should still be qcom_scm_call.
> > 
> > You mean s/scm_legacy_call_atomic/qcom_scm_call/ right?
> > 
> > I don't really want to resend the rest of the patches if this last one
> > is the only one that needs an update. This was a semi-RFC anyway so
> > maybe it's fine if the first 5 patches get merged and then I can resend
> > this one? Otherwise I will resend this again next week or so with less
> > diff for this patch.
> 
> I'm fine with merging the first 5, but was hoping that Elliot could
> provide either a "Reviewed-by" or at least an "Acked-by" on these.
> 

I'll take the silence as I should resend the whole series?