From: David Howells <dhowells@redhat.com>
To: linux-cachefs@redhat.com, linux-afs@lists.infradead.org
Cc: Christoph Hellwig <hch@lst.de>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-mm@kvack.org, dhowells@redhat.com,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] cachefiles, afs: mm wait fixes
Date: Tue, 23 Mar 2021 11:53:22 +0000 [thread overview]
Message-ID: <161650040278.2445805.7652115256944270457.stgit@warthog.procyon.org.uk> (raw)
Here are some patches to fix page waiting-related issues in cachefiles and
afs[1]:
(1) In cachefiles, remove the use of the wait_bit_key struct to access
something that's actually in wait_page_key format. The proper struct
is now available in the header, so that should be used instead.
(2) Add a proper wait function for waiting killably on the page writeback
flag. This includes a recent bugfix here (presumably commit
c2407cf7d22d0c0d94cf20342b3b8f06f1d904e7).
(3) In afs, use the function added in (2) rather than using
wait_on_page_bit_killable() which doesn't have the aforementioned
bugfix.
Note that I modified this to work with the upstream code where the
page pointer isn't cached in a local variable.
The patches can be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes
David
Link: https://lore.kernel.org/r/20210320054104.1300774-1-willy@infradead.org[1]
---
Matthew Wilcox (Oracle) (3):
fs/cachefiles: Remove wait_bit_key layout dependency
mm/writeback: Add wait_on_page_writeback_killable
afs: Use wait_on_page_writeback_killable
fs/afs/write.c | 3 +--
include/linux/pagemap.h | 1 +
mm/page-writeback.c | 16 ++++++++++++++++
3 files changed, 18 insertions(+), 2 deletions(-)
next reply other threads:[~2021-03-23 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 11:53 David Howells [this message]
2021-03-23 11:53 ` [PATCH 1/3] fs/cachefiles: Remove wait_bit_key layout dependency David Howells
2021-03-23 11:53 ` [PATCH 2/3] mm/writeback: Add wait_on_page_writeback_killable David Howells
2021-03-23 11:53 ` [PATCH 3/3] afs: Use wait_on_page_writeback_killable David Howells
2021-03-23 12:08 ` [PATCH 0/3] cachefiles, afs: mm wait fixes Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161650040278.2445805.7652115256944270457.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.