[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove obj->mm.lock! (rev19)

From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove obj->mm.lock! (rev19)
Date: Wed, 24 Mar 2021 12:44:23 -0000	[thread overview]
Message-ID: <161658986348.19037.6730086681214480169@emeril.freedesktop.org> (raw)
In-Reply-To: <20210323155059.628690-1-maarten.lankhorst@linux.intel.com>

== Series Details ==

Series: drm/i915: Remove obj->mm.lock! (rev19)
URL   : https://patchwork.freedesktop.org/series/82337/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f2f3d15b07cd drm/i915: Do not share hwsp across contexts any more, v8.
-:565: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#565: FILE: drivers/gpu/drm/i915/gt/intel_timeline.c:286:
+	if (TIMELINE_SEQNO_BYTES <= BIT(5) && (next_ofs & BIT(5)))

total: 0 errors, 1 warnings, 0 checks, 967 lines checked
dd6b0831f824 drm/i915: Pin timeline map after first timeline pin, v4.
-:16: WARNING:TYPO_SPELLING: 'arithmatic' may be misspelled - perhaps 'arithmetic'?
#16: 
- Fix NULL + XX arithmatic, use casts. (kbuild)
                ^^^^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 288 lines checked
e747b5a66262 drm/i915: Move cmd parser pinning to execbuffer
f9d4561631e8 drm/i915: Add missing -EDEADLK handling to execbuf pinning, v2.
-:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#59: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:452:
+		err = i915_vma_pin_ww(vma, &eb->ww,
 					     entry->pad_to_size,

total: 0 errors, 0 warnings, 1 checks, 75 lines checked
35b116fcc9ea drm/i915: Ensure we hold the object mutex in pin correctly.
9ac3e1ad6487 drm/i915: Add gem object locking to madvise.
e6572ea0afd5 drm/i915: Move HAS_STRUCT_PAGE to obj->flags
-:110: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#110: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:63:
+			  struct lock_class_key *key, unsigned flags)

-:133: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#133: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:53:
+			  unsigned alloc_flags);

total: 0 errors, 2 warnings, 0 checks, 350 lines checked
fb3105de5e0a drm/i915: Rework struct phys attachment handling
604b6dd53a23 drm/i915: Convert i915_gem_object_attach_phys() to ww locking, v2.
7a8d57cfb1b9 drm/i915: make lockdep slightly happier about execbuf.
e3be2c7ee753 drm/i915: Disable userptr pread/pwrite support.
89563fe547df drm/i915: No longer allow exporting userptr through dma-buf
d23647f81abc drm/i915: Reject more ioctls for userptr, v2.
2be23f28351b drm/i915: Reject UNSYNCHRONIZED for userptr, v2.
01e5685490be drm/i915: Make compilation of userptr code depend on MMU_NOTIFIER.
69f0b61a7b66 drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.
-:336: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#336: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:605:
+static inline int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:337: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#337: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:606:
+static inline int i915_gem_object_userptr_submit_done(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:338: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#338: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:607:
+static inline void i915_gem_object_userptr_submit_fini(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); }

-:339: WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#339: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:608:
+static inline int i915_gem_object_userptr_validate(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:398: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#398: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2:
  * SPDX-License-Identifier: MIT

-:402: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#402: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:6:
+ *
+  * Based on amdgpu_mn, which bears the following notice:

-:403: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#403: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:7:
+  * Based on amdgpu_mn, which bears the following notice:
+ *

-:488: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#488: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:63:
+	struct drm_i915_gem_object *obj = container_of(mni, struct drm_i915_gem_object, userptr.notifier);

-:1176: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1176: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:300:
+	pinned = ret = 0;

-:1191: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1191: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:315:
+	if (mmu_interval_read_retry(&obj->userptr.notifier,
+		!obj->userptr.page_ref ? notifier_seq :

-:1338: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#1338: FILE: drivers/gpu/drm/i915/i915_drv.h:564:
+	spinlock_t notifier_lock;

total: 0 errors, 8 warnings, 3 checks, 1267 lines checked
3d0d50b2e548 drm/i915: Flatten obj->mm.lock
2f83508e63d5 drm/i915: Populate logical context during first pin.
296ebb3ca034 drm/i915: Make ring submission compatible with obj->mm.lock removal, v2.
04a410dbb633 drm/i915: Handle ww locking in init_status_page
f85c237c33ac drm/i915: Rework clflush to work correctly without obj->mm.lock.
736efe12efc4 drm/i915: Pass ww ctx to intel_pin_to_display_plane
9a0dbf433859 drm/i915: Add object locking to vm_fault_cpu
6af3ef7f5246 drm/i915: Move pinning to inside engine_wa_list_verify()
-:72: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#72: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:2215:
+	err = i915_vma_pin_ww(vma, &ww, 0, 0,
+			   i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER);

total: 0 errors, 0 warnings, 1 checks, 118 lines checked
aa8dafd5125e drm/i915: Take reservation lock around i915_vma_pin.
671403460031 drm/i915: Make lrc_init_wa_ctx compatible with ww locking, v3.
1d9e2b1a0405 drm/i915: Make __engine_unpark() compatible with ww locking.
-:10: WARNING:REPEATED_WORD: Possible repeated word: 'many'
#10: 
many many places where rpm is used, I chose the safest option

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
baedd2415a58 drm/i915: Take obj lock around set_domain ioctl
-:85: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#85: FILE: drivers/gpu/drm/i915/gem/i915_gem_domain.c:518:
+		err = i915_gem_object_wait(obj,
+					  I915_WAIT_INTERRUPTIBLE |

total: 0 errors, 0 warnings, 1 checks, 74 lines checked
50c0931d366a drm/i915: Defer pin calls in buffer pool until first use by caller.
f6e7879dabe3 drm/i915: Fix pread/pwrite to work with new locking rules.
-:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 349 lines checked
f89028ebe93f drm/i915: Fix workarounds selftest, part 1
aba89877a4e3 drm/i915: Prepare for obj->mm.lock removal, v2.
-:136: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Thomas Hellström" <thomas.hellstrom@intel.com>' != 'Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>'

total: 0 errors, 1 warnings, 0 checks, 96 lines checked
e15b66ef7c0a drm/i915: Add igt_spinner_pin() to allow for ww locking around spinner.
381f59ff8365 drm/i915: Add ww locking around vm_access()
39a8452f67ba drm/i915: Increase ww locking for perf.
48ae3768e16f drm/i915: Lock ww in ucode objects correctly
6624e17b46e9 drm/i915: Add ww locking to dma-buf ops, v2.
b8c627b7b31e drm/i915: Add missing ww lock in intel_dsb_prepare.
159abb16fd82 drm/i915: Fix ww locking in shmem_create_from_object
266422b377b3 drm/i915: Use a single page table lock for each gtt.
-:112: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#112: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:85:
+		return i915_gem_object_lock(vm->scratch[0], ww);
+	} else {

total: 0 errors, 1 warnings, 0 checks, 154 lines checked
19c3e972dcbe drm/i915/selftests: Prepare huge_pages testcases for obj->mm.lock removal.
00f331e776db drm/i915/selftests: Prepare client blit for obj->mm.lock removal.
8fbb8e8028ae drm/i915/selftests: Prepare coherency tests for obj->mm.lock removal.
ef440a231423 drm/i915/selftests: Prepare context tests for obj->mm.lock removal.
431757d3b0cf drm/i915/selftests: Prepare dma-buf tests for obj->mm.lock removal.
6b79c1ece060 drm/i915/selftests: Prepare execbuf tests for obj->mm.lock removal.
e90ca54d1588 drm/i915/selftests: Prepare mman testcases for obj->mm.lock removal.
c127f7834259 drm/i915/selftests: Prepare object tests for obj->mm.lock removal.
5a8ba3c68f93 drm/i915/selftests: Prepare object blit tests for obj->mm.lock removal.
353b198fd4f3 drm/i915/selftests: Prepare igt_gem_utils for obj->mm.lock removal
a30f2a574fc6 drm/i915/selftests: Prepare context selftest for obj->mm.lock removal
5260b516a0b4 drm/i915/selftests: Prepare hangcheck for obj->mm.lock removal
5dc1c66912d5 drm/i915/selftests: Prepare execlists and lrc selftests for obj->mm.lock removal
-:163: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#163: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1303:
+	lrc = i915_gem_object_pin_map_unlocked(ce->state->obj,
 				      i915_coherent_map_type(engine->i915));

total: 0 errors, 0 warnings, 1 checks, 130 lines checked
4dd3d0a41383 drm/i915/selftests: Prepare mocs tests for obj->mm.lock removal
191880d613cb drm/i915/selftests: Prepare ring submission for obj->mm.lock removal
9d7a0ca250e2 drm/i915/selftests: Prepare timeline tests for obj->mm.lock removal
c46141f1c8a9 drm/i915/selftests: Prepare i915_request tests for obj->mm.lock removal
bf5b62cc1b09 drm/i915/selftests: Prepare memory region tests for obj->mm.lock removal
a9348f7d7af5 drm/i915/selftests: Prepare cs engine tests for obj->mm.lock removal
645f38afdfb6 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal
639c726b63d3 drm/i915: Finally remove obj->mm.lock.
3c31e30a540f drm/i915: Keep userpointer bindings if seqcount is unchanged, v2.
b60fda6f637c drm/i915: Move gt_revoke() slightly
f30f8d856dc0 drm/i915: Add missing -EDEADLK path in execbuffer ggtt pinning.
937b7b336124 drm/i915: Fix pin_map in scheduler selftests
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
1b8a97bf76e4 drm/i915: Add ww parameter to get_pages() callback
f19b90e4051f drm/i915: Add ww context to prepare_(read/write)
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6: 
This will allow us to explicitly pass the ww to pin_pages, when it starts taking it.

total: 0 errors, 1 warnings, 0 checks, 107 lines checked
1838932ac410 drm/i915: Pass ww ctx to pin_map, v2.
-:461: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#461: FILE: drivers/gpu/drm/i915/i915_perf.c:1665:
+	batch = cs = i915_gem_object_pin_map(bo, &ww, I915_MAP_WB);

total: 0 errors, 0 warnings, 1 checks, 339 lines checked
773dc3de6596 drm/i915: Pass ww ctx to i915_gem_object_pin_pages
-:80: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#80: FILE: drivers/gpu/drm/i915/gem/i915_gem_domain.c:464:
+		err = i915_gem_object_wait(obj,
+					  I915_WAIT_INTERRUPTIBLE |

total: 0 errors, 0 warnings, 1 checks, 332 lines checked
d4dd9871da73 drm/i915: Remove asynchronous vma binding

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx