From: "thermal-bot for brian-sy yang" <tip-bot2@linutronix.de>
To: linux-pm@vger.kernel.org
Cc: "brian-sy yang" <brian-sy.yang@mediatek.com>,
Michael Kao <michael.kao@mediatek.com>,
Lukasz Luba <lukasz.luba@arm.com>,
stable@vger.kernel.org, #v5.7@tip-bot2.tec.linutronix.de,
Daniel Lezcano <daniel.lezcano@linaro.org>,
rui.zhang@intel.com, amitk@kernel.org
Subject: [thermal: thermal/next] thermal/drivers/cpufreq_cooling: Fix slab OOB issue
Date: Thu, 15 Apr 2021 12:04:01 -0000 [thread overview]
Message-ID: <161848824126.29796.11373237838275688493.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20201229050831.19493-1-michael.kao@mediatek.com>
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 34ab17cc6c2c1ac93d7e5d53bb972df9a968f085
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//34ab17cc6c2c1ac93d7e5d53bb972df9a968f085
Author: brian-sy yang <brian-sy.yang@mediatek.com>
AuthorDate: Tue, 29 Dec 2020 13:08:31 +08:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Thu, 15 Apr 2021 13:21:42 +02:00
thermal/drivers/cpufreq_cooling: Fix slab OOB issue
Slab OOB issue is scanned by KASAN in cpu_power_to_freq().
If power is limited below the power of OPP0 in EM table,
it will cause slab out-of-bound issue with negative array
index.
Return the lowest frequency if limited power cannot found
a suitable OPP in EM table to fix this issue.
Backtrace:
[<ffffffd02d2a37f0>] die+0x104/0x5ac
[<ffffffd02d2a5630>] bug_handler+0x64/0xd0
[<ffffffd02d288ce4>] brk_handler+0x160/0x258
[<ffffffd02d281e5c>] do_debug_exception+0x248/0x3f0
[<ffffffd02d284488>] el1_dbg+0x14/0xbc
[<ffffffd02d75d1d4>] __kasan_report+0x1dc/0x1e0
[<ffffffd02d75c2e0>] kasan_report+0x10/0x20
[<ffffffd02d75def8>] __asan_report_load8_noabort+0x18/0x28
[<ffffffd02e6fce5c>] cpufreq_power2state+0x180/0x43c
[<ffffffd02e6ead80>] power_actor_set_power+0x114/0x1d4
[<ffffffd02e6fac24>] allocate_power+0xaec/0xde0
[<ffffffd02e6f9f80>] power_allocator_throttle+0x3ec/0x5a4
[<ffffffd02e6ea888>] handle_thermal_trip+0x160/0x294
[<ffffffd02e6edd08>] thermal_zone_device_check+0xe4/0x154
[<ffffffd02d351cb4>] process_one_work+0x5e4/0xe28
[<ffffffd02d352f44>] worker_thread+0xa4c/0xfac
[<ffffffd02d360124>] kthread+0x33c/0x358
[<ffffffd02d289940>] ret_from_fork+0xc/0x18
Fixes: 371a3bc79c11b ("thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from power")
Signed-off-by: brian-sy yang <brian-sy.yang@mediatek.com>
Signed-off-by: Michael Kao <michael.kao@mediatek.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Cc: stable@vger.kernel.org #v5.7
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201229050831.19493-1-michael.kao@mediatek.com
---
drivers/thermal/cpufreq_cooling.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
index f3d3084..eeb4e4b 100644
--- a/drivers/thermal/cpufreq_cooling.c
+++ b/drivers/thermal/cpufreq_cooling.c
@@ -116,7 +116,7 @@ static u32 cpu_power_to_freq(struct cpufreq_cooling_device *cpufreq_cdev,
{
int i;
- for (i = cpufreq_cdev->max_level; i >= 0; i--) {
+ for (i = cpufreq_cdev->max_level; i > 0; i--) {
if (power >= cpufreq_cdev->em->table[i].power)
break;
}
prev parent reply other threads:[~2021-04-15 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 5:08 [PATCH v2] thermal: cpufreq_cooling: fix slab OOB issue Michael Kao
2020-12-29 5:08 ` Michael Kao
2020-12-29 5:08 ` Michael Kao
2021-03-30 2:51 ` Michael Kao
2021-03-30 2:51 ` Michael Kao
2021-03-30 2:51 ` Michael Kao
2021-03-30 8:42 ` Lukasz Luba
2021-03-30 8:42 ` Lukasz Luba
2021-03-30 8:42 ` Lukasz Luba
2021-03-31 16:54 ` Daniel Lezcano
2021-03-31 16:54 ` Daniel Lezcano
2021-03-31 16:54 ` Daniel Lezcano
2021-04-15 12:04 ` thermal-bot for brian-sy yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161848824126.29796.11373237838275688493.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=#v5.7@tip-bot2.tec.linutronix.de \
--cc=amitk@kernel.org \
--cc=brian-sy.yang@mediatek.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=michael.kao@mediatek.com \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.