From: patchwork-bot+linux-soc@kernel.org
To: Joel Stanley <joel@jms.id.au>
Cc: soc@kernel.org
Subject: Re: [PATCH] soc: aspeed: fix a ternary sign expansion bug
Date: Fri, 23 Apr 2021 09:30:08 +0000 [thread overview]
Message-ID: <161917020859.11881.1649913001330046634.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210423000919.1249474-1-joel@jms.id.au>
Hello:
This patch was applied to soc/soc.git (refs/heads/for-next):
On Fri, 23 Apr 2021 09:39:19 +0930 you wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> The intent here was to return negative error codes but it actually
> returns positive values. The problem is that type promotion with
> ternary operations is quite complicated.
>
> "ret" is an int. "copied" is a u32. And the snoop_file_read() function
> returns long. What happens is that "ret" is cast to u32 and becomes
> positive then it's cast to long and it's still positive.
>
> [...]
Here is the summary with links:
- soc: aspeed: fix a ternary sign expansion bug
https://git.kernel.org/soc/soc/c/d42805807be7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2021-04-23 9:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 0:09 [PATCH] soc: aspeed: fix a ternary sign expansion bug Joel Stanley
2021-04-23 9:30 ` patchwork-bot+linux-soc [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-22 9:11 Dan Carpenter
2021-04-22 9:24 ` Al Viro
2021-04-22 9:26 ` Al Viro
2021-04-22 14:56 ` Patrick Venture
2021-04-22 16:21 ` David Laight
2021-04-23 0:07 ` Joel Stanley
2021-04-23 7:43 ` Dan Carpenter
2021-04-23 10:45 ` Sergey Organov
2021-04-23 10:54 ` David Laight
2021-04-23 11:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161917020859.11881.1649913001330046634.git-patchwork-notify@kernel.org \
--to=patchwork-bot+linux-soc@kernel.org \
--cc=joel@jms.id.au \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.