All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH 2/5] generic/{094,225}: fix argument to _require_file_block_size_equals_fs_block_size
Date: Tue, 27 Apr 2021 21:09:06 -0700	[thread overview]
Message-ID: <161958294676.3452351.8192861960078318002.stgit@magnolia> (raw)
In-Reply-To: <161958293466.3452351.14394620932744162301.stgit@magnolia>

From: Darrick J. Wong <djwong@kernel.org>

Fix the incorrect parameter being passed to this new predicate.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 common/rc         |    3 ++-
 tests/generic/094 |    2 +-
 tests/generic/225 |    2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)


diff --git a/common/rc b/common/rc
index 2cf550ec..6752c92d 100644
--- a/common/rc
+++ b/common/rc
@@ -4174,7 +4174,8 @@ _get_block_size()
 }
 
 # Require that the fundamental allocation unit of a file is the same as the
-# filesystem block size.
+# filesystem block size.  The sole parameter must be the root dir of a
+# filesystem.
 _require_file_block_size_equals_fs_block_size()
 {
 	local file_alloc_unit="$(_get_file_block_size $1)"
diff --git a/tests/generic/094 b/tests/generic/094
index 8c292473..20ef158e 100755
--- a/tests/generic/094
+++ b/tests/generic/094
@@ -43,7 +43,7 @@ _require_test_program "fiemap-tester"
 # FIEMAP test doesn't like finding unwritten blocks after it punches out
 # a partial rt extent.
 test "$FSTYP" = "xfs" && \
-	_require_file_block_size_equals_fs_block_size $fiemapfile
+	_require_file_block_size_equals_fs_block_size $SCRATCH_MNT
 
 seed=`date +%s`
 
diff --git a/tests/generic/225 b/tests/generic/225
index fac688df..1a7963e8 100755
--- a/tests/generic/225
+++ b/tests/generic/225
@@ -43,7 +43,7 @@ _require_test_program "fiemap-tester"
 # FIEMAP test doesn't like finding unwritten blocks after it punches out
 # a partial rt extent.
 test "$FSTYP" = "xfs" && \
-	_require_file_block_size_equals_fs_block_size $fiemapfile
+	_require_file_block_size_equals_fs_block_size $SCRATCH_MNT
 
 seed=`date +%s`
 


  parent reply	other threads:[~2021-04-28  4:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  4:08 [PATCHSET 0/5] fstests: miscellaneous fixes Darrick J. Wong
2021-04-28  4:09 ` [PATCH 1/5] xfs/276: remove unnecessary mkfs golden output Darrick J. Wong
2021-04-28 17:47   ` Brian Foster
2021-04-28  4:09 ` Darrick J. Wong [this message]
2021-04-28 17:47   ` [PATCH 2/5] generic/{094,225}: fix argument to _require_file_block_size_equals_fs_block_size Brian Foster
2021-04-28  4:09 ` [PATCH 3/5] generic/449: always fill up the data device Darrick J. Wong
2021-04-28 17:47   ` Brian Foster
2021-04-29  0:39     ` Darrick J. Wong
2021-04-28  4:09 ` [PATCH 4/5] xfs/004: don't fail test due to realtime files Darrick J. Wong
2021-04-28 17:47   ` Brian Foster
2021-04-28  4:09 ` [PATCH 5/5] xfs/49[12]: skip pre-lazysbcount filesystems Darrick J. Wong
2021-04-28 17:47   ` Brian Foster
2021-04-29  0:44     ` Darrick J. Wong
2021-04-29  1:31   ` [PATCH v1.2 " Darrick J. Wong
2021-04-29 13:30     ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161958294676.3452351.8192861960078318002.stgit@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.