From: Waiman Long <longman@redhat.com>
To: john.p.donnelly@oracle.com,
chenguanyou <chenguanyou9338@gmail.com>,
gregkh@linuxfoundation.org
Cc: dave@stgolabs.net, hdanton@sina.com,
linux-kernel@vger.kernel.org, mazhenhua@xiaomi.com,
mingo@redhat.com, peterz@infradead.org, quic_aiquny@quicinc.com,
will@kernel.org, sashal@kernel.org
Subject: Re: [PATCH v5] locking/rwsem: Make handoff bit handling more consistent
Date: Mon, 11 Apr 2022 17:07:38 -0400 [thread overview]
Message-ID: <161c2e25-3d26-4dd7-d378-d1741f7bcca8@redhat.com> (raw)
In-Reply-To: <31178c33-e25c-c3e8-35e2-776b5211200c@oracle.com>
On 4/11/22 17:03, john.p.donnelly@oracle.com wrote:
>
>>>
>>> I have reached out to Waiman and he suggested this for our next test
>>> pass:
>>>
>>>
>>> 1ee326196c6658 locking/rwsem: Always try to wake waiters in
>>> out_nolock path
>>
>> Does this commit help to avoid the lockup problem?
>>
>> Commit 1ee326196c6658 fixes a potential missed wakeup problem when a
>> reader first in the wait queue is interrupted out without acquiring
>> the lock. It is actually not a fix for commit d257cc8cb8d5. However,
>> this commit changes the out_nolock path behavior of writers by
>> leaving the handoff bit set when the wait queue isn't empty. That
>> likely makes the missed wakeup problem easier to reproduce.
>>
>> Cheers,
>> Longman
>>
>
> Hi,
>
>
> We are testing now
>
> ETA for fio soak test completion is ~15hr from now.
>
> I wanted to share the stack traces for future reference + occurrences.
>
I am looking forward to your testing results tomorrow.
Cheers,
Longman
next prev parent reply other threads:[~2022-04-11 21:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 1:29 [PATCH v5] locking/rwsem: Make handoff bit handling more consistent Waiman Long
2021-11-16 2:52 ` Aiqun(Maria) Yu
2021-11-16 9:14 ` Peter Zijlstra
2021-11-16 9:24 ` Peter Zijlstra
2021-11-16 14:52 ` Waiman Long
2021-11-17 13:36 ` Peter Zijlstra
2021-11-23 8:53 ` [tip: locking/urgent] " tip-bot2 for Waiman Long
2022-02-14 15:47 ` Re:[PATCH v5] " chenguanyou
2022-02-14 16:01 ` [PATCH " Greg KH
2022-04-11 18:26 ` john.p.donnelly
2022-04-11 18:40 ` Waiman Long
2022-04-11 21:03 ` john.p.donnelly
2022-04-11 21:07 ` Waiman Long [this message]
2022-04-12 16:28 ` john.p.donnelly
2022-04-12 17:04 ` Waiman Long
2022-04-14 10:48 ` Greg KH
2022-04-14 15:18 ` Waiman Long
2022-04-14 15:42 ` Greg KH
2022-04-14 15:44 ` Waiman Long
2022-04-20 13:55 ` john.p.donnelly
2022-04-26 20:21 ` Waiman Long
2022-04-26 21:22 ` john.p.donnelly
2022-02-14 16:22 ` chenguanyou
2022-02-15 7:41 ` [PATCH " Greg KH
2022-02-16 16:30 ` Waiman Long
2022-02-17 15:41 ` chenguanyou
2022-03-14 8:07 ` [PATCH " Greg KH
2022-03-22 2:49 ` chenguanyou
2022-03-24 12:51 ` [PATCH " Greg KH
2022-07-19 0:27 ` Doug Anderson
2022-07-19 10:41 ` Hillf Danton
2022-07-19 15:30 ` Doug Anderson
2022-07-22 11:55 ` Hillf Danton
2022-07-22 14:02 ` Doug Anderson
2022-07-23 0:17 ` Hillf Danton
2022-07-23 1:27 ` Hillf Danton
2022-08-05 17:14 ` Doug Anderson
2022-08-05 19:02 ` Waiman Long
2022-08-05 19:16 ` Doug Anderson
2022-08-30 16:18 ` Doug Anderson
2022-08-31 11:08 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161c2e25-3d26-4dd7-d378-d1741f7bcca8@redhat.com \
--to=longman@redhat.com \
--cc=chenguanyou9338@gmail.com \
--cc=dave@stgolabs.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=john.p.donnelly@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mazhenhua@xiaomi.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_aiquny@quicinc.com \
--cc=sashal@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.