Re: [RFC PATCH v1 0/7] migration/snapshot: External snapshot utility - no-reply

From: no-reply@patchew.org
To: andrey.gruzdev@virtuozzo.com
Cc: vsementsov@virtuozzo.com, quintela@redhat.com, armbru@redhat.com,
	david@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com,
	dgilbert@redhat.com, pbonzini@redhat.com, den@openvz.org,
	andrey.gruzdev@virtuozzo.com
Subject: Re: [RFC PATCH v1 0/7] migration/snapshot: External snapshot utility
Date: Wed, 12 May 2021 13:18:50 -0700 (PDT)	[thread overview]
Message-ID: <162085072855.19352.5018907357316733321@d887ba82c771> (raw)
In-Reply-To: <20210512192619.537268-1-andrey.gruzdev@virtuozzo.com>

Patchew URL: https://patchew.org/QEMU/20210512192619.537268-1-andrey.gruzdev@virtuozzo.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210512192619.537268-1-andrey.gruzdev@virtuozzo.com
Subject: [RFC PATCH v1 0/7] migration/snapshot: External snapshot utility

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   3158964..3e9f48b  master     -> master
 - [tag update]      patchew/20210511163151.45167-1-kwolf@redhat.com -> patchew/20210511163151.45167-1-kwolf@redhat.com
 * [new tag]         patchew/20210512192619.537268-1-andrey.gruzdev@virtuozzo.com -> patchew/20210512192619.537268-1-andrey.gruzdev@virtuozzo.com
Switched to a new branch 'test'
87d9eb7 migration/snapshot: Implementation of qemu-snapshot load path in postcopy mode
dece241 migration/snapshot: Implementation of qemu-snapshot load path
cbaa5b9 migration/snapshot: Implementation of qemu-snapshot save path
f9dd5c5 migration/snapshot: Block layer AIO support in qemu-snapshot
ed9b73d migration/snapshot: Move RAM_SAVE_FLAG_xxx defines to migration/ram.h
92f9263 migration/snapshot: Introduce qemu_ftell2() routine
32c347a migration/snapshot: Introduce qemu-snapshot tool

=== OUTPUT BEGIN ===
1/7 Checking commit 32c347a19ef4 (migration/snapshot: Introduce qemu-snapshot tool)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

WARNING: line over 80 characters
#227: FILE: qemu-snapshot.c:63:
+    int postcopy_percent;       /* Start postcopy after % of normal pages loaded */

WARNING: line over 80 characters
#274: FILE: qemu-snapshot.c:110:
+static BlockBackend *image_open_opts(const char *optstr, QDict *options, int flags)

ERROR: switch and case should be at the same indent
#414: FILE: qemu-snapshot.c:250:
+        switch (c) {
+            case '?':
[...]
+            case 'h':
[...]
+            case 'V':
[...]
+            case 'T':
[...]
+            case 'r':
[...]
+            case OPTION_POSTCOPY:
[...]
+            case OPTION_PAGE_SIZE:
[...]
+            case OPTION_URI:
[...]
+            default:

ERROR: trailing whitespace
#436: FILE: qemu-snapshot.c:272:
+                $

ERROR: consider using qemu_strtol in preference to strtol
#449: FILE: qemu-snapshot.c:285:
+                postcopy_percent = strtol(optarg, &r, 10);

WARNING: line over 80 characters
#450: FILE: qemu-snapshot.c:286:
+                if (*r != '\0' || postcopy_percent < 0 || postcopy_percent > 100) {

ERROR: consider using qemu_strtol in preference to strtol
#468: FILE: qemu-snapshot.c:304:
+                target_page_size = strtol(optarg, &r, 0);

WARNING: line over 80 characters
#469: FILE: qemu-snapshot.c:305:
+                if (*r != '\0' || (target_page_size & (target_page_size - 1)) != 0 ||

ERROR: space required after that ',' (ctx:VxV)
#494: FILE: qemu-snapshot.c:330:
+                    fd = strtol(p, &r,10);
                                      ^

ERROR: consider using qemu_strtol in preference to strtol
#494: FILE: qemu-snapshot.c:330:
+                    fd = strtol(p, &r,10);

total: 6 errors, 5 warnings, 563 lines checked

Patch 1/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/7 Checking commit 92f92637b84c (migration/snapshot: Introduce qemu_ftell2() routine)
3/7 Checking commit ed9b73da773a (migration/snapshot: Move RAM_SAVE_FLAG_xxx defines to migration/ram.h)
WARNING: Block comments use a leading /* on a separate line
#51: FILE: migration/ram.h:36:
+/* RAM_SAVE_FLAG_ZERO used to be named RAM_SAVE_FLAG_COMPRESS, it

total: 0 errors, 1 warnings, 44 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/7 Checking commit f9dd5c542600 (migration/snapshot: Block layer AIO support in qemu-snapshot)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#81: 
new file mode 100644

total: 0 errors, 1 warnings, 314 lines checked

Patch 4/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/7 Checking commit cbaa5b9bd2a6 (migration/snapshot: Implementation of qemu-snapshot save path)
WARNING: line over 80 characters
#554: FILE: qemu-snapshot-vm.c:507:
+            error_report("RAM page with unknown combination of flags 0x%x", flags);

WARNING: line over 80 characters
#648: FILE: qemu-snapshot-vm.c:601:
+                         (size_t)(ssize_t) (VMSTATE_HEADER_EOF_OFFSET - eof_pos));

WARNING: line over 80 characters
#832: FILE: qemu-snapshot-vm.c:783:
+             * Normally we will never get here since the ending part of migration

total: 0 errors, 3 warnings, 901 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/7 Checking commit dece2418c08d (migration/snapshot: Implementation of qemu-snapshot load path)
ERROR: trailing whitespace
#296: FILE: qemu-snapshot-vm.c:996:
+        $

ERROR: switch and case should be at the same indent
#435: FILE: qemu-snapshot-vm.c:1135:
+        switch (flags) {
+            case RAM_SAVE_FLAG_MEM_SIZE:
[...]
+            case RAM_SAVE_FLAG_EOS:
[...]
+            default:

WARNING: line over 80 characters
#446: FILE: qemu-snapshot-vm.c:1146:
+                error_report("Unknown combination of RAM page flags 0x%x", flags);

WARNING: line over 80 characters
#765: FILE: qemu-snapshot.c:258:
+    s->aio_ring = aio_ring_new(ram_load_aio_co, AIO_RING_SIZE, AIO_RING_INFLIGHT);

total: 2 errors, 2 warnings, 741 lines checked

Patch 6/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/7 Checking commit 87d9eb785185 (migration/snapshot: Implementation of qemu-snapshot load path in postcopy mode)
WARNING: line over 80 characters
#517: FILE: qemu-snapshot-vm.c:1272:
+    send_command(s->f_fd, MIG_CMD_PACKAGED, sizeof(length), (uint8_t *) &length);

WARNING: line over 80 characters
#603: FILE: qemu-snapshot-vm.c:1836:
+        if (!res && s->postcopy && !s->in_postcopy && is_postcopy_switchover(s)) {

total: 0 errors, 2 warnings, 628 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20210512192619.537268-1-andrey.gruzdev@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com