From: no-reply@patchew.org
To: berrange@redhat.com
Cc: fam@euphon.net, peter.maydell@linaro.org, thuth@redhat.com,
berrange@redhat.com, alex.bennee@linaro.org,
qemu-devel@nongnu.org, wainersm@redhat.com, f4bug@amsat.org,
willianr@redhat.com, philmd@redhat.com
Subject: Re: [PATCH v3 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles
Date: Thu, 13 May 2021 03:39:54 -0700 (PDT) [thread overview]
Message-ID: <162090239324.30499.17267871061237343801@d887ba82c771> (raw)
In-Reply-To: <20210513095519.1213675-1-berrange@redhat.com>
Patchew URL: https://patchew.org/QEMU/20210513095519.1213675-1-berrange@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210513095519.1213675-1-berrange@redhat.com
Subject: [PATCH v3 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210508014802.892561-1-richard.henderson@linaro.org -> patchew/20210508014802.892561-1-richard.henderson@linaro.org
* [new tag] patchew/20210513095519.1213675-1-berrange@redhat.com -> patchew/20210513095519.1213675-1-berrange@redhat.com
Switched to a new branch 'test'
73a0045 tests/docker: remove ubuntu container
d6b42f9 tests/docker: auto-generate opensuse-leap with lcitool
8a2b437 tests/docker: auto-generate ubuntu2004 with lcitool
dd19e03 tests/docker: auto-generate ubuntu1804 with lcitool
931d434 tests/docker: auto-generate fedora with lcitool
8402c0d tests/docker: auto-generate centos8 with lcitool
f581c7c tests/docker: add script for automating container refresh
95ad785 tests/docker: expand opensuse-leap package list
790f77d tests/docker: expand ubuntu2004 package list
0c357e1 tests/docker: expand ubuntu1804 package list
a29a532 tests/docker: expand fedora package list
f1df3d0 tests/docker: expand centos8 package list
a7c131e tests/docker: remove mingw packages from Fedora
37ce608 tests/docker: fix mistakes in ubuntu package lists
977b03d tests/docker: fix mistakes in fedora package list
b3580ed tests/docker: fix mistakes in centos package lists
5757744 tests/docker: fix sorting in package lists
826c380 tests/docker: remove FEATURES env var from templates
fad3849 tests/docker: use explicit docker.io registry
5098f17 tests/docker: use project specific container registries
2dc7c73 tests/docker: don't use BUILDKIT in GitLab either
f10a2d6 hw/usb/ccid: remove references to NSS
=== OUTPUT BEGIN ===
1/22 Checking commit f10a2d6c78d1 (hw/usb/ccid: remove references to NSS)
2/22 Checking commit 2dc7c735b228 (tests/docker: don't use BUILDKIT in GitLab either)
3/22 Checking commit 5098f173e564 (tests/docker: use project specific container registries)
4/22 Checking commit fad3849eb138 (tests/docker: use explicit docker.io registry)
5/22 Checking commit 826c380cbbc9 (tests/docker: remove FEATURES env var from templates)
6/22 Checking commit 57577442850f (tests/docker: fix sorting in package lists)
7/22 Checking commit b3580edfbd81 (tests/docker: fix mistakes in centos package lists)
8/22 Checking commit 977b03d43f95 (tests/docker: fix mistakes in fedora package list)
9/22 Checking commit 37ce60848186 (tests/docker: fix mistakes in ubuntu package lists)
10/22 Checking commit a7c131edc9b6 (tests/docker: remove mingw packages from Fedora)
11/22 Checking commit f1df3d0229f6 (tests/docker: expand centos8 package list)
12/22 Checking commit a29a53287642 (tests/docker: expand fedora package list)
13/22 Checking commit 0c357e188a91 (tests/docker: expand ubuntu1804 package list)
14/22 Checking commit 790f77db86dc (tests/docker: expand ubuntu2004 package list)
15/22 Checking commit 95ad7854e308 (tests/docker: expand opensuse-leap package list)
16/22 Checking commit f581c7c94392 (tests/docker: add script for automating container refresh)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#106:
new file mode 100755
total: 0 errors, 1 warnings, 109 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 8402c0d0f253 (tests/docker: auto-generate centos8 with lcitool)
18/22 Checking commit 931d434d8aef (tests/docker: auto-generate fedora with lcitool)
19/22 Checking commit dd19e0388006 (tests/docker: auto-generate ubuntu1804 with lcitool)
20/22 Checking commit 8a2b437a4498 (tests/docker: auto-generate ubuntu2004 with lcitool)
ERROR: line over 90 characters
#28: FILE: tests/docker/dockerfiles-refresh.py:65:
+ "RUN sed -i 's/^const/static const/g' /usr/lib/llvm-10/lib/clang/10.0.0/include/sanitizer/tsan_interface.h\n"]
total: 1 errors, 0 warnings, 266 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit d6b42f932077 (tests/docker: auto-generate opensuse-leap with lcitool)
22/22 Checking commit 73a00450ba05 (tests/docker: remove ubuntu container)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
deleted file mode 100644
total: 0 errors, 1 warnings, 11 lines checked
Patch 22/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210513095519.1213675-1-berrange@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2021-05-13 10:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 9:54 [PATCH v3 00/22] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles Daniel P. Berrangé
2021-05-13 9:54 ` [PATCH v3 01/22] hw/usb/ccid: remove references to NSS Daniel P. Berrangé
2021-05-13 9:54 ` [PATCH v3 02/22] tests/docker: don't use BUILDKIT in GitLab either Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 03/22] tests/docker: use project specific container registries Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 04/22] tests/docker: use explicit docker.io registry Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 05/22] tests/docker: remove FEATURES env var from templates Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 06/22] tests/docker: fix sorting in package lists Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 07/22] tests/docker: fix mistakes in centos " Daniel P. Berrangé
2021-05-13 10:14 ` Philippe Mathieu-Daudé
2021-05-13 9:55 ` [PATCH v3 08/22] tests/docker: fix mistakes in fedora package list Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 09/22] tests/docker: fix mistakes in ubuntu package lists Daniel P. Berrangé
2021-05-13 10:12 ` Philippe Mathieu-Daudé
2021-05-13 10:15 ` Daniel P. Berrangé
2021-05-13 10:19 ` Philippe Mathieu-Daudé
2021-05-13 9:55 ` [PATCH v3 10/22] tests/docker: remove mingw packages from Fedora Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 11/22] tests/docker: expand centos8 package list Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 12/22] tests/docker: expand fedora " Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 13/22] tests/docker: expand ubuntu1804 " Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 14/22] tests/docker: expand ubuntu2004 " Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 15/22] tests/docker: expand opensuse-leap " Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 16/22] tests/docker: add script for automating container refresh Daniel P. Berrangé
2021-05-13 10:18 ` Philippe Mathieu-Daudé
2021-05-13 9:55 ` [PATCH v3 17/22] tests/docker: auto-generate centos8 with lcitool Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 18/22] tests/docker: auto-generate fedora " Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 19/22] tests/docker: auto-generate ubuntu1804 " Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 20/22] tests/docker: auto-generate ubuntu2004 " Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 21/22] tests/docker: auto-generate opensuse-leap " Daniel P. Berrangé
2021-05-13 9:55 ` [PATCH v3 22/22] tests/docker: remove ubuntu container Daniel P. Berrangé
2021-05-13 10:39 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162090239324.30499.17267871061237343801@d887ba82c771 \
--to=no-reply@patchew.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.