Re: [PULL 00/11] Ui 20210521 patches - no-reply

From: no-reply@patchew.org
To: kraxel@redhat.com
Cc: pbonzini@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org,
	marcandre.lureau@redhat.com, armbru@redhat.com
Subject: Re: [PULL 00/11] Ui 20210521 patches
Date: Fri, 21 May 2021 06:09:51 -0700 (PDT)	[thread overview]
Message-ID: <162160259004.20339.6786648370861749325@0addf061776e> (raw)
In-Reply-To: <20210521125119.3173309-1-kraxel@redhat.com>

Patchew URL: https://patchew.org/QEMU/20210521125119.3173309-1-kraxel@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210521125119.3173309-1-kraxel@redhat.com
Subject: [PULL 00/11] Ui 20210521 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210521125119.3173309-1-kraxel@redhat.com -> patchew/20210521125119.3173309-1-kraxel@redhat.com
Switched to a new branch 'test'
6620e56 ui/gtk: add clipboard support
e49030e ui/gtk: move struct GtkDisplayState to ui/gtk.h
8b242b6 ui/vnc: clipboard support
6bb54b4 ui/vdagent: add clipboard support
29ac93c ui/vdagent: add mouse support
1f34d34 ui/vdagent: core infrastructure
fde97a6 ui: add clipboard documentation
4af3865 ui: add clipboard infrastructure
ddbe639 build: add separate spice-protocol config option
2d9b49f ui/spice-display: check NULL pointer in interface_release_resource()
9b35ed2 vnc: spelling fix (enable->enabled)

=== OUTPUT BEGIN ===
1/11 Checking commit 9b35ed2d6285 (vnc: spelling fix (enable->enabled))
2/11 Checking commit 2d9b49ff5b85 (ui/spice-display: check NULL pointer in interface_release_resource())
3/11 Checking commit ddbe639f67c9 (build: add separate spice-protocol config option)
4/11 Checking commit 4af38659ec52 (ui: add clipboard infrastructure)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 161 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/11 Checking commit fde97a69a5b3 (ui: add clipboard documentation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

WARNING: line over 80 characters
#92: FILE: include/ui/clipboard.h:43:
+ * @QEMU_CLIPBOARD_SELECTION_PRIMARY: primary selection (select + middle mouse button).

total: 0 errors, 2 warnings, 194 lines checked

Patch 5/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/11 Checking commit 1f34d34394a4 (ui/vdagent: core infrastructure)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#105: 
new file mode 100644

ERROR: if this code is redundant consider removing it
#163: FILE: ui/vdagent.c:54:
+#if 0

WARNING: line over 80 characters
#165: FILE: ui/vdagent.c:56:
+    [VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB] = "clipboard-no-release-on-regrab",

ERROR: if this code is redundant consider removing it
#186: FILE: ui/vdagent.c:77:
+#if 0

WARNING: line over 80 characters
#247: FILE: ui/vdagent.c:138:
+                                               sizeof(VDAgentAnnounceCapabilities) +

total: 2 errors, 3 warnings, 412 lines checked

Patch 6/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/11 Checking commit 29ac93cf036e (ui/vdagent: add mouse support)
8/11 Checking commit 6bb54b44dd36 (ui/vdagent: add clipboard support)
ERROR: if this code is redundant consider removing it
#124: FILE: ui/vdagent.c:120:
+#if 0

WARNING: line over 80 characters
#444: FILE: ui/vdagent.c:759:
+    cfg->clipboard = qemu_opt_get_bool(opts, "clipboard", VDAGENT_CLIPBOARD_DEFAULT);

total: 1 errors, 1 warnings, 394 lines checked

Patch 8/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/11 Checking commit 8b242b60adb3 (ui/vnc: clipboard support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

WARNING: line over 80 characters
#283: FILE: ui/vnc-clipboard.c:243:
+void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, uint8_t *data)

WARNING: line over 80 characters
#292: FILE: ui/vnc-clipboard.c:252:
+            qemu_clipboard_info_new(&vs->cbpeer, QEMU_CLIPBOARD_SELECTION_CLIPBOARD);

WARNING: line over 80 characters
#336: FILE: ui/vnc-clipboard.c:296:
+        qemu_clipboard_info_new(&vs->cbpeer, QEMU_CLIPBOARD_SELECTION_CLIPBOARD);

WARNING: line over 80 characters
#503: FILE: ui/vnc.h:643:
+void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, uint8_t *data);

total: 0 errors, 5 warnings, 451 lines checked

Patch 9/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit e49030e96e91 (ui/gtk: move struct GtkDisplayState to ui/gtk.h)
11/11 Checking commit 6620e56dcf7e (ui/gtk: add clipboard support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#55: 
new file mode 100644

WARNING: line over 80 characters
#138: FILE: ui/gtk-clipboard.c:79:
+    GtkDisplayState *gd = container_of(notifier, GtkDisplayState, cbpeer.update);

total: 0 errors, 2 warnings, 233 lines checked

Patch 11/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20210521125119.3173309-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com