Re: [PATCH V3 1/3] arm64: dts: sc7280: Add QSPI node

From: Stephen Boyd <sboyd@kernel.org>
To: Roja Rani Yarubandi <rojay@codeaurora.org>,
	agross@kernel.org, bjorn.andersson@linaro.org,
	robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Rajendra Nayak <rnayak@codeaurora.org>,
	saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com,
	Roja Rani Yarubandi <rojay@codeaurora.org>
Subject: Re: [PATCH V3 1/3] arm64: dts: sc7280: Add QSPI node
Date: Fri, 04 Jun 2021 14:45:56 -0700	[thread overview]
Message-ID: <162284315655.1835121.6817703229350764867@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210604135439.19119-2-rojay@codeaurora.org>

Quoting Roja Rani Yarubandi (2021-06-04 06:54:37)
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 3900cfc09562..d0edffc15736 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -268,6 +268,22 @@ pmr735b_die_temp {
>                 };
>  };
>  
> +&qspi {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&qspi_clk>, <&qspi_cs0>, <&qspi_data01>;
> +
> +       flash@0 {
> +               compatible = "jedec,spi-nor";
> +               reg = <0>;
> +
> +               /* TODO: Increase frequency after testing */

Is this going to change? Please set it to 37.5MHz if that's the max
supported.

> +               spi-max-frequency = <25000000>;
> +               spi-tx-bus-width = <2>;
> +               spi-rx-bus-width = <2>;
> +       };
> +};
> +
>  &qupv3_id_0 {
>         status = "okay";
>  };