From: patchwork-bot+netdevbpf@kernel.org
To: Tatsuhiko Yasumatsu <th.yasumatsu@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] bpf: Fix integer overflow involving bucket_size
Date: Fri, 06 Aug 2021 23:10:05 +0000 [thread overview]
Message-ID: <162829140571.10198.14853046999783152739.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210806150419.109658-1-th.yasumatsu@gmail.com>
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Sat, 7 Aug 2021 00:04:18 +0900 you wrote:
> In __htab_map_lookup_and_delete_batch(), hash buckets are iterated over
> to count the number of elements in each bucket (bucket_size).
> If bucket_size is large enough, the multiplication to calculate
> kvmalloc() size could overflow, resulting in out-of-bounds write
> as reported by KASAN.
>
> [...]
> [ 104.986052] BUG: KASAN: vmalloc-out-of-bounds in __htab_map_lookup_and_delete_batch+0x5ce/0xb60
> [ 104.986489] Write of size 4194224 at addr ffffc9010503be70 by task crash/112
> [ 104.986889]
> [ 104.987193] CPU: 0 PID: 112 Comm: crash Not tainted 5.14.0-rc4 #13
> [ 104.987552] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014
> [ 104.988104] Call Trace:
> [ 104.988410] dump_stack_lvl+0x34/0x44
> [ 104.988706] print_address_description.constprop.0+0x21/0x140
> [ 104.988991] ? __htab_map_lookup_and_delete_batch+0x5ce/0xb60
> [ 104.989327] ? __htab_map_lookup_and_delete_batch+0x5ce/0xb60
> [ 104.989622] kasan_report.cold+0x7f/0x11b
> [ 104.989881] ? __htab_map_lookup_and_delete_batch+0x5ce/0xb60
> [ 104.990239] kasan_check_range+0x17c/0x1e0
> [ 104.990467] memcpy+0x39/0x60
> [ 104.990670] __htab_map_lookup_and_delete_batch+0x5ce/0xb60
> [ 104.990982] ? __wake_up_common+0x4d/0x230
> [ 104.991256] ? htab_of_map_free+0x130/0x130
> [ 104.991541] bpf_map_do_batch+0x1fb/0x220
> [...]
>
> [...]
Here is the summary with links:
- [v2] bpf: Fix integer overflow involving bucket_size
https://git.kernel.org/bpf/bpf/c/ccd37ad9ef0a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-08-06 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 15:04 [PATCH v2] bpf: Fix integer overflow involving bucket_size Tatsuhiko Yasumatsu
2021-08-06 23:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162829140571.10198.14853046999783152739.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=th.yasumatsu@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.