From: "tip-bot2 for Zhen Lei" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Hulk Robot <hulkci@huawei.com>,
Zhen Lei <thunder.leizhen@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/core] genirq/timings: Fix error return code in irq_timings_test_irqs()
Date: Wed, 11 Aug 2021 12:36:47 -0000 [thread overview]
Message-ID: <162868540746.395.5341157331429759306.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210811093333.2376-1-thunder.leizhen@huawei.com>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 290fdc4b7ef14e33d0e30058042b0e9bfd02b89b
Gitweb: https://git.kernel.org/tip/290fdc4b7ef14e33d0e30058042b0e9bfd02b89b
Author: Zhen Lei <thunder.leizhen@huawei.com>
AuthorDate: Wed, 11 Aug 2021 17:33:32 +08:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 11 Aug 2021 14:33:35 +02:00
genirq/timings: Fix error return code in irq_timings_test_irqs()
Return a negative error code from the error handling case instead of 0, as
done elsewhere in this function.
Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com
---
kernel/irq/timings.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index d309d6f..59affb3 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -794,12 +794,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)
__irq_timings_store(irq, irqs, ti->intervals[i]);
if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
+ ret = -EBADSLT;
pr_err("Failed to store in the circular buffer\n");
goto out;
}
}
if (irqs->count != ti->count) {
+ ret = -ERANGE;
pr_err("Count differs\n");
goto out;
}
next prev parent reply other threads:[~2021-08-11 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 9:33 [PATCH v2] genirq/timings: Fix error return code in irq_timings_test_irqs() Zhen Lei
2021-08-11 12:36 ` tip-bot2 for Zhen Lei [this message]
2021-08-13 18:32 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162868540746.395.5341157331429759306.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.