From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Hans de Goede" <hdegoede@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Add privacy-screen class and connector properties (rev4)
Date: Mon, 06 Sep 2021 08:46:20 -0000 [thread overview]
Message-ID: <163091798099.30428.7601661388155153042@emeril.freedesktop.org> (raw)
In-Reply-To: <20210906073519.4615-1-hdegoede@redhat.com>
== Series Details ==
Series: drm: Add privacy-screen class and connector properties (rev4)
URL : https://patchwork.freedesktop.org/series/79259/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
bc1b50a446f7 drm/connector: Add support for privacy-screen properties (v4)
-:30: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#30:
Co-authored-by: Hans de Goede <hdegoede@redhat.com>
-:150: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#150: FILE: drivers/gpu/drm/drm_connector.c:2408:
+ drm_property_create_enum(connector->dev, DRM_MODE_PROP_ENUM,
+ "privacy-screen sw-state",
-:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#155: FILE: drivers/gpu/drm/drm_connector.c:2413:
+ drm_property_create_enum(connector->dev,
+ DRM_MODE_PROP_IMMUTABLE | DRM_MODE_PROP_ENUM,
total: 0 errors, 1 warnings, 2 checks, 205 lines checked
103f4901ff19 drm: Add privacy-screen class (v3)
-:131: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#131:
new file mode 100644
-:168: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#168: FILE: drivers/gpu/drm/drm_privacy_screen.c:33:
+#define to_drm_privacy_screen(dev) \
+ container_of(dev, struct drm_privacy_screen, dev)
-:216: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#216: FILE: drivers/gpu/drm/drm_privacy_screen.c:81:
+static struct drm_privacy_screen *drm_privacy_screen_get_by_name(
-:417: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#417: FILE: drivers/gpu/drm/drm_privacy_screen.c:282:
+}
+/*
-:479: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#479: FILE: drivers/gpu/drm/drm_privacy_screen.c:344:
+struct drm_privacy_screen *drm_privacy_screen_register(
-:575: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#575: FILE: include/drm/drm_privacy_screen_consumer.h:33:
+}
+static inline void drm_privacy_screen_put(struct drm_privacy_screen *priv)
-:578: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#578: FILE: include/drm/drm_privacy_screen_consumer.h:36:
+}
+static inline int drm_privacy_screen_set_sw_state(struct drm_privacy_screen *priv,
-:583: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#583: FILE: include/drm/drm_privacy_screen_consumer.h:41:
+}
+static inline void drm_privacy_screen_get_state(struct drm_privacy_screen *priv,
-:674: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#674: FILE: include/drm/drm_privacy_screen_driver.h:76:
+struct drm_privacy_screen *drm_privacy_screen_register(
-:721: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#721: FILE: include/drm/drm_privacy_screen_machine.h:37:
+}
+static inline void drm_privacy_screen_lookup_exit(void)
total: 0 errors, 1 warnings, 9 checks, 640 lines checked
4c5269c0a347 drm/privacy-screen: Add X86 specific arch init code
-:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#30:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 110 lines checked
5112840ff391 drm/privacy-screen: Add notifier support
-:122: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#122: FILE: include/drm/drm_privacy_screen_consumer.h:53:
}
+static inline int drm_privacy_screen_register_notifier(struct drm_privacy_screen *priv,
-:127: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#127: FILE: include/drm/drm_privacy_screen_consumer.h:58:
+}
+static inline int drm_privacy_screen_unregister_notifier(struct drm_privacy_screen *priv,
total: 0 errors, 0 warnings, 2 checks, 123 lines checked
016dd07be125 drm/connector: Add a drm_connector privacy-screen helper functions
-:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#59: FILE: drivers/gpu/drm/drm_connector.c:555:
+ drm_privacy_screen_register_notifier(connector->privacy_screen,
+ &connector->privacy_screen_notifier);
-:69: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#69: FILE: drivers/gpu/drm/drm_connector.c:593:
+ drm_privacy_screen_unregister_notifier(
-:80: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#80: FILE: drivers/gpu/drm/drm_connector.c:2461:
+static void drm_connector_update_privacy_screen_properties(
-:90: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#90: FILE: drivers/gpu/drm/drm_connector.c:2471:
+ drm_object_property_set_value(&connector->base,
+ connector->privacy_screen_hw_state_property, hw_state);
-:93: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#93: FILE: drivers/gpu/drm/drm_connector.c:2474:
+static int drm_connector_privacy_screen_notifier(
-:105: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#105: FILE: drivers/gpu/drm/drm_connector.c:2486:
+ drm_sysfs_connector_status_event(connector,
+ connector->privacy_screen_sw_state_property);
-:107: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#107: FILE: drivers/gpu/drm/drm_connector.c:2488:
+ drm_sysfs_connector_status_event(connector,
+ connector->privacy_screen_hw_state_property);
-:124: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#124: FILE: drivers/gpu/drm/drm_connector.c:2505:
+void drm_connector_attach_privacy_screen_provider(
-:166: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#166: FILE: drivers/gpu/drm/drm_connector.c:2547:
+ ret = drm_privacy_screen_set_sw_state(connector->privacy_screen,
+ new_connector_state->privacy_screen_sw_state);
-:217: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#217: FILE: include/drm/drm_connector.h:1787:
+void drm_connector_attach_privacy_screen_provider(
total: 0 errors, 0 warnings, 10 checks, 185 lines checked
dbce67d00f3d platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper
4493056b11ea platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once
d68628f78bef platform/x86: thinkpad_acpi: Register a privacy-screen device
-:90: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#90: FILE: drivers/platform/x86/thinkpad_acpi.c:9845:
+ priv->hw_state = priv->sw_state = state;
-:107: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#107: FILE: drivers/platform/x86/thinkpad_acpi.c:9856:
+ priv->hw_state = priv->sw_state = output & 0x1;
total: 0 errors, 0 warnings, 2 checks, 183 lines checked
ff55a0aefb53 drm/i915: Add privacy-screen support
next prev parent reply other threads:[~2021-09-06 8:46 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 7:35 [PATCH 0/9] drm: Add privacy-screen class and connector properties Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] " Hans de Goede
2021-09-06 7:35 ` [PATCH 1/9] drm/connector: Add support for privacy-screen properties (v4) Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] " Hans de Goede
2021-09-15 19:48 ` Lyude Paul
2021-09-15 19:48 ` [Intel-gfx] " Lyude Paul
2021-09-15 19:48 ` Lyude Paul
2021-09-16 8:26 ` Jani Nikula
2021-09-16 8:26 ` [Intel-gfx] " Jani Nikula
2021-09-06 7:35 ` [PATCH 2/9] drm: Add privacy-screen class (v3) Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] " Hans de Goede
2021-09-15 20:01 ` Lyude Paul
2021-09-15 20:01 ` [Intel-gfx] " Lyude Paul
2021-09-15 20:01 ` Lyude Paul
2021-09-16 8:49 ` Hans de Goede
2021-09-16 8:49 ` [Intel-gfx] " Hans de Goede
2021-09-06 7:35 ` [PATCH 3/9] drm/privacy-screen: Add X86 specific arch init code Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] " Hans de Goede
2021-09-16 8:51 ` Jani Nikula
2021-09-16 8:51 ` [Intel-gfx] " Jani Nikula
2021-09-16 9:18 ` Hans de Goede
2021-09-16 9:18 ` [Intel-gfx] " Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] [PATCH 4/9] drm/privacy-screen: Add notifier support Hans de Goede
2021-09-06 7:35 ` Hans de Goede
2021-09-15 20:26 ` Lyude Paul
2021-09-15 20:26 ` Lyude Paul
2021-09-15 20:26 ` [Intel-gfx] " Lyude Paul
2021-09-16 9:06 ` Hans de Goede
2021-09-16 9:06 ` [Intel-gfx] " Hans de Goede
2021-09-16 16:50 ` Lyude Paul
2021-09-16 16:50 ` Lyude Paul
2021-09-16 16:50 ` [Intel-gfx] " Lyude Paul
2021-09-06 7:35 ` [PATCH 5/9] drm/connector: Add a drm_connector privacy-screen helper functions Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] " Hans de Goede
2021-09-06 7:35 ` [PATCH 6/9] platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] " Hans de Goede
2021-09-06 7:35 ` [PATCH 7/9] platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] " Hans de Goede
2021-09-06 7:35 ` [PATCH 8/9] platform/x86: thinkpad_acpi: Register a privacy-screen device Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] " Hans de Goede
2021-09-15 20:55 ` Lyude Paul
2021-09-15 20:55 ` [Intel-gfx] " Lyude Paul
2021-09-15 20:55 ` Lyude Paul
2021-09-16 9:09 ` Hans de Goede
2021-09-16 9:09 ` [Intel-gfx] " Hans de Goede
2021-09-06 7:35 ` [PATCH 9/9] drm/i915: Add privacy-screen support Hans de Goede
2021-09-06 7:35 ` [Intel-gfx] " Hans de Goede
2021-09-15 21:11 ` Lyude Paul
2021-09-15 21:11 ` [Intel-gfx] " Lyude Paul
2021-09-15 21:11 ` Lyude Paul
2021-09-16 9:12 ` Hans de Goede
2021-09-16 9:12 ` [Intel-gfx] " Hans de Goede
2021-09-16 9:40 ` Jani Nikula
2021-09-16 9:40 ` [Intel-gfx] " Jani Nikula
2021-09-16 10:32 ` Hans de Goede
2021-09-16 10:32 ` [Intel-gfx] " Hans de Goede
2021-09-20 21:06 ` Lyude Paul
2021-09-20 21:06 ` Lyude Paul
2021-09-20 21:06 ` [Intel-gfx] " Lyude Paul
2021-09-16 14:04 ` Ville Syrjälä
2021-09-16 14:04 ` [Intel-gfx] " Ville Syrjälä
2021-09-17 14:23 ` Hans de Goede
2021-09-17 14:23 ` [Intel-gfx] " Hans de Goede
2021-09-16 13:45 ` Ville Syrjälä
2021-09-16 13:45 ` [Intel-gfx] " Ville Syrjälä
2021-09-17 14:37 ` Hans de Goede
2021-09-17 14:37 ` [Intel-gfx] " Hans de Goede
2021-09-17 16:25 ` Ville Syrjälä
2021-09-17 16:25 ` [Intel-gfx] " Ville Syrjälä
2021-09-17 16:42 ` Hans de Goede
2021-09-17 16:42 ` [Intel-gfx] " Hans de Goede
2021-09-17 17:04 ` Ville Syrjälä
2021-09-17 17:04 ` [Intel-gfx] " Ville Syrjälä
2021-09-06 8:46 ` Patchwork [this message]
2021-09-06 8:49 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Add privacy-screen class and connector properties (rev4) Patchwork
2021-09-06 9:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-06 11:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-15 21:12 ` [PATCH 0/9] drm: Add privacy-screen class and connector properties Lyude Paul
2021-09-15 21:12 ` [Intel-gfx] " Lyude Paul
2021-09-15 21:12 ` Lyude Paul
2021-09-16 9:30 ` Hans de Goede
2021-09-16 9:30 ` [Intel-gfx] " Hans de Goede
2021-09-16 10:14 ` Jani Nikula
2021-09-16 10:14 ` [Intel-gfx] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163091798099.30428.7601661388155153042@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.