From: patchwork-bot+netdevbpf@kernel.org
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, kuba@kernel.org, buytenh@marvell.com,
afleming@freescale.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, yanfei.xu@windriver.com
Subject: Re: [PATCH v4 1/2] Revert "net: mdiobus: Fix memory leak in __mdiobus_register"
Date: Fri, 01 Oct 2021 00:40:07 +0000 [thread overview]
Message-ID: <163304880731.17936.15226510469738244218.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <f12fb1faa4eccf0f355788225335eb4309ff2599.1633024062.git.paskripkin@gmail.com>
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Thu, 30 Sep 2021 20:49:42 +0300 you wrote:
> This reverts commit ab609f25d19858513919369ff3d9a63c02cd9e2e.
>
> This patch is correct in the sense that we _should_ call device_put() in
> case of device_register() failure, but the problem in this code is more
> vast.
>
> We need to set bus->state to UNMDIOBUS_REGISTERED before calling
> device_register() to correctly release the device in mdiobus_free().
> This patch prevents us from doing it, since in case of device_register()
> failure put_device() will be called 2 times and it will cause UAF or
> something else.
>
> [...]
Here is the summary with links:
- [v4,1/2] Revert "net: mdiobus: Fix memory leak in __mdiobus_register"
https://git.kernel.org/netdev/net/c/10eff1f5788b
- [v4,2/2] phy: mdio: fix memory leak
https://git.kernel.org/netdev/net/c/ca6e11c337da
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-10-01 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 17:49 [PATCH v4 1/2] Revert "net: mdiobus: Fix memory leak in __mdiobus_register" Pavel Skripkin
2021-09-30 17:50 ` [PATCH v4 2/2] phy: mdio: fix memory leak Pavel Skripkin
2021-10-01 0:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163304880731.17936.15226510469738244218.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=afleming@freescale.com \
--cc=andrew@lunn.ch \
--cc=buytenh@marvell.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=yanfei.xu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.