From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v1] powerpc/64s/interrupt: Fix check_return_regs_valid false positive
Date: Tue, 02 Nov 2021 21:11:57 +1100 [thread overview]
Message-ID: <163584791735.1845480.147504591640251031.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20211026122531.3599918-1-npiggin@gmail.com>
On Tue, 26 Oct 2021 22:25:31 +1000, Nicholas Piggin wrote:
> The check_return_regs_valid can cause a false positive if the return
> regs are marked as norestart and they are an HSRR type interrupt,
> because the low bit in the bottom of regs->trap causes interrupt
> type matching to fail.
>
> This can occcur for example on bare metal with a HV privileged doorbell
> interrupt that causes a signal, but do_signal returns early because
> get_signal() fails, and takes the "No signal to deliver" path. In this
> case no signal was delivered so the return location is not changed so
> return SRRs are not invalidated, yet set_trap_norestart is called, which
> messes up the match. Building go-1.16.6 is known to reproduce this.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/64s/interrupt: Fix check_return_regs_valid false positive
https://git.kernel.org/powerpc/c/4a5cb51f3db4be547225a4bce7a43d41b231382b
cheers
prev parent reply other threads:[~2021-11-02 11:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 12:25 [PATCH v1] powerpc/64s/interrupt: Fix check_return_regs_valid false positive Nicholas Piggin
2021-11-02 10:11 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163584791735.1845480.147504591640251031.b4-ty@ellerman.id.au \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.