From: Jens Axboe <axboe@kernel.dk>
To: Luis Chamberlain <mcgrof@kernel.org>, hare@suse.de, hch@infradead.org
Cc: linux-block@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
kernel test robot <lkp@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: fix device_add_disk() kobject_create_and_add() error handling
Date: Wed, 03 Nov 2021 13:28:49 -0600 [thread overview]
Message-ID: <163596772995.186346.6961527014377680159.b4-ty@kernel.dk> (raw)
In-Reply-To: <20211103164023.1384821-1-mcgrof@kernel.org>
On Wed, 3 Nov 2021 09:40:23 -0700, Luis Chamberlain wrote:
> Commit 83cbce957446 ("block: add error handling for device_add_disk /
> add_disk") added error handling to device_add_disk(), however the goto
> label for the kobject_create_and_add() failure did not set the return
> value correctly, and so we can end up in a situation where
> kobject_create_and_add() fails but we report success.
>
>
> [...]
Applied, thanks!
[1/1] block: fix device_add_disk() kobject_create_and_add() error handling
commit: 3554ce121f632db1f56f4e28dfe37da846617c9c
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2021-11-03 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 16:40 [PATCH] block: fix device_add_disk() kobject_create_and_add() error handling Luis Chamberlain
2021-11-03 16:41 ` Christoph Hellwig
2021-11-03 19:28 ` Jens Axboe [this message]
2021-11-04 10:55 ` Wu Bo
2021-11-04 10:57 ` Wu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163596772995.186346.6961527014377680159.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.