From: Kalle Valo <kvalo@codeaurora.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
linux-arm-msm@vger.kernel.org, loic.poulain@linaro.org,
benl@squareup.com, johannes@sipsolutions.net,
bryan.odonoghue@linaro.org
Subject: Re: [PATCH v3 1/3] wcn36xx: Fix DMA channel enable/disable cycle
Date: Mon, 8 Nov 2021 13:21:30 +0000 (UTC) [thread overview]
Message-ID: <163637768555.12783.6992853094190522078.kvalo@codeaurora.org> (raw)
In-Reply-To: <20211105122152.1580542-2-bryan.odonoghue@linaro.org>
Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
> Right now we have a broken sequence where we enable DMA channel interrupts
> which can be left enabled and never disabled if we hit an error path.
>
> Worse still when we unload the driver, the DMA channel interrupt bits are
> left intact. About the only saving grace here is that we do remember to
> disable the wcnss interrupt when unload the driver.
>
> Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
3 patches applied to ath-next branch of ath.git, thanks.
89dcb1da611d wcn36xx: Fix DMA channel enable/disable cycle
3652096e5263 wcn36xx: Release DMA channel descriptor allocations
ed04ea76e69e wcn36xx: Put DXE block into reset before freeing memory
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211105122152.1580542-2-bryan.odonoghue@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-11-08 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 12:21 [PATCH v3 0/3] wcn36xx: Fix DMA buffer allocation and free logic Bryan O'Donoghue
2021-11-05 12:21 ` [PATCH v3 1/3] wcn36xx: Fix DMA channel enable/disable cycle Bryan O'Donoghue
2021-11-08 13:21 ` Kalle Valo [this message]
2021-11-05 12:21 ` [PATCH v3 2/3] wcn36xx: Release DMA channel descriptor allocations Bryan O'Donoghue
2021-11-05 12:21 ` [PATCH v3 3/3] wcn36xx: Put DXE block into reset before freeing memory Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163637768555.12783.6992853094190522078.kvalo@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=benl@squareup.com \
--cc=bryan.odonoghue@linaro.org \
--cc=johannes@sipsolutions.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.