From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
ChanghuiZhong <czhong@redhat.com>
Subject: Re: [PATCH V2] blk-mq: cancel blk-mq dispatch work in both blk_cleanup_queue and disk_release()
Date: Mon, 15 Nov 2021 19:22:19 -0700 [thread overview]
Message-ID: <163702933960.92052.4155589861281419870.b4-ty@kernel.dk> (raw)
In-Reply-To: <20211116014343.610501-1-ming.lei@redhat.com>
On Tue, 16 Nov 2021 09:43:43 +0800, Ming Lei wrote:
> For avoiding to slow down queue destroy, we don't call
> blk_mq_quiesce_queue() in blk_cleanup_queue(), instead of delaying to
> cancel dispatch work in blk_release_queue().
>
> However, this way has caused kernel oops[1], reported by Changhui. The log
> shows that scsi_device can be freed before running blk_release_queue(),
> which is expected too since scsi_device is released after the scsi disk
> is closed and the scsi_device is removed.
>
> [...]
Applied, thanks!
[1/1] blk-mq: cancel blk-mq dispatch work in both blk_cleanup_queue and disk_release()
commit: 2a19b28f7929866e1cec92a3619f4de9f2d20005
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2021-11-16 5:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 1:43 [PATCH V2] blk-mq: cancel blk-mq dispatch work in both blk_cleanup_queue and disk_release() Ming Lei
2021-11-16 2:22 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163702933960.92052.4155589861281419870.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=czhong@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.