From: Julien Grall <julien@xen.org>
To: Pawel Wieczorkiewicz <wipawel@amazon.de>, xen-devel@lists.xen.org
Cc: semelpaul@gmail.com, andrew.cooper3@citrix.com,
nmanthey@amazon.de, wipawel@xen.org, paul@xen.org
Subject: Re: [XTF 0/4] Add strncmp(), strtol() and strtoul() functions
Date: Thu, 23 Apr 2020 12:06:10 +0100 [thread overview]
Message-ID: <1637c166-75f5-4034-e3a0-6921aabbdfab@xen.org> (raw)
In-Reply-To: <20200423101918.13566-1-wipawel@amazon.de>
On 23/04/2020 11:19, Pawel Wieczorkiewicz wrote:
> Add FreeBSD's implementation of strtol() and strtoul() functions from:
> https://github.com/freebsd/freebsd/blob/master/lib/libc/stdlib/strtoul.c
I would suggest to specify the baseline used in each commit. This will
allows us to track any changes that was made afterwards (even if it
seems unlikely) in the FreeBSD code base.
>
> The FreeBSD code being added as a separate file (common/libc/strtol.c)
> is under the BSD 3-clause license. Modification to COPYING file might
> be needed.
>
> Also add simple implementation of the strncmp() function.
>
> Paul Semel (1):
> string: add freebds libc implementation of strtol()
>
> Pawel Wieczorkiewicz (3):
> libc, strtol: Add isspace(), isdigit(), isxdigit(), isascii()
> libc, strtol: Add FreeBSD libc implementation of strtoul()
> libc: add strncmp() function
>
> build/files.mk | 1 +
> common/lib.c | 8 --
> common/libc/string.c | 11 +++
> common/libc/strtol.c | 201 ++++++++++++++++++++++++++++++++++++++++++++++++
> common/libc/vsnprintf.c | 8 --
> include/xtf/libc.h | 35 +++++++++
> 6 files changed, 248 insertions(+), 16 deletions(-)
> create mode 100644 common/libc/strtol.c
>
--
Julien Grall
prev parent reply other threads:[~2020-04-23 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 10:19 [XTF 0/4] Add strncmp(), strtol() and strtoul() functions Pawel Wieczorkiewicz
2020-04-23 10:19 ` [XTF 1/4] string: add freebds libc implementation of strtol() Pawel Wieczorkiewicz
2020-04-23 10:19 ` [XTF 2/4] libc, strtol: Add isspace(), isdigit(), isxdigit(), isascii() Pawel Wieczorkiewicz
2020-04-23 10:19 ` [XTF 3/4] libc, strtol: Add FreeBSD libc implementation of strtoul() Pawel Wieczorkiewicz
2020-04-23 10:19 ` [XTF 4/4] libc: add strncmp() function Pawel Wieczorkiewicz
2020-04-23 11:06 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1637c166-75f5-4034-e3a0-6921aabbdfab@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=nmanthey@amazon.de \
--cc=paul@xen.org \
--cc=semelpaul@gmail.com \
--cc=wipawel@amazon.de \
--cc=wipawel@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.