From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Roman Bolshakov <r.bolshakov@yadro.com>, target-devel@vger.kernel.org
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Rajan Shanmugavelu <rajan.shanmugavelu@oracle.com>,
linux-scsi@vger.kernel.org, stable@vger.kernel.org,
linux@yadro.com
Subject: Re: [PATCH] scsi: qla2xxx: Format log strings only if needed
Date: Mon, 6 Dec 2021 22:45:57 -0500 [thread overview]
Message-ID: <163884867622.17909.10048645834482460757.b4-ty@oracle.com> (raw)
In-Reply-To: <20211112145446.51210-1-r.bolshakov@yadro.com>
On Fri, 12 Nov 2021 17:54:46 +0300, Roman Bolshakov wrote:
> Commit 598a90f2002c4 ("scsi: qla2xxx: add ring buffer for tracing debug
> logs") introduced unconditional log string formatting to ql_dbg() even
> if ql_dbg_log event is disabled. It harms performance because some
> strings are formatted in fastpath and/or interrupt context.
>
>
Applied to 5.16/scsi-fixes, thanks!
[1/1] scsi: qla2xxx: Format log strings only if needed
https://git.kernel.org/mkp/scsi/c/69002c8ce914
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-12-07 3:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 14:54 [PATCH] scsi: qla2xxx: Format log strings only if needed Roman Bolshakov
2021-12-07 3:45 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163884867622.17909.10048645834482460757.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=r.bolshakov@yadro.com \
--cc=rajan.shanmugavelu@oracle.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.