From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Arunpravin" <arunpravin.paneerselvam@amd.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v7,1/6] drm: move the buddy allocator from i915 into common drm
Date: Sun, 09 Jan 2022 14:43:54 -0000 [thread overview]
Message-ID: <164173943420.4447.3401337905466288273@emeril.freedesktop.org> (raw)
In-Reply-To: <20220109141951.134432-1-Arunpravin.PaneerSelvam@amd.com>
== Series Details ==
Series: series starting with [v7,1/6] drm: move the buddy allocator from i915 into common drm
URL : https://patchwork.freedesktop.org/series/98641/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
da013685b6f1 drm: move the buddy allocator from i915 into common drm
-:81: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#81:
new file mode 100644
-:106: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#106: FILE: drivers/gpu/drm/drm_buddy.c:21:
+ BUG_ON(order > DRM_BUDDY_MAX_ORDER);
-:116: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#116: FILE: drivers/gpu/drm/drm_buddy.c:31:
+ BUG_ON(block->header & DRM_BUDDY_HEADER_UNUSED);
-:185: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#185: FILE: drivers/gpu/drm/drm_buddy.c:100:
+ BUG_ON(mm->max_order > DRM_BUDDY_MAX_ORDER);
-:225: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#225: FILE: drivers/gpu/drm/drm_buddy.c:140:
+ BUG_ON(i > mm->max_order);
-:226: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#226: FILE: drivers/gpu/drm/drm_buddy.c:141:
+ BUG_ON(drm_buddy_block_size(mm, root) < chunk_size);
-:276: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#276: FILE: drivers/gpu/drm/drm_buddy.c:191:
+ BUG_ON(!drm_buddy_block_is_free(block));
-:277: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#277: FILE: drivers/gpu/drm/drm_buddy.c:192:
+ BUG_ON(!drm_buddy_block_order(block));
-:284: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#284: FILE: drivers/gpu/drm/drm_buddy.c:199:
+ block->right = drm_block_alloc(mm, block, block_order,
+ offset + (mm->chunk_size << block_order));
-:346: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#346: FILE: drivers/gpu/drm/drm_buddy.c:261:
+ BUG_ON(!drm_buddy_block_is_allocated(block));
-:403: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#403: FILE: drivers/gpu/drm/drm_buddy.c:318:
+ BUG_ON(!drm_buddy_block_is_free(block));
-:585: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#585: FILE: drivers/gpu/drm/drm_buddy.c:500:
+ BUG_ON(!drm_buddy_block_is_free(block));
total: 0 errors, 11 warnings, 1 checks, 944 lines checked
f2a20e1dc926 drm: improve drm_buddy_alloc function
-:379: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#379: FILE: drivers/gpu/drm/drm_buddy.c:580:
+ BUG_ON(order > mm->max_order);
-:380: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#380: FILE: drivers/gpu/drm/drm_buddy.c:581:
+ BUG_ON(order < min_order);
-:507: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#507: FILE: drivers/gpu/drm/i915/i915_ttm_buddy_manager.c:88:
+ err = drm_buddy_alloc_blocks(mm, (u64)place->fpfn << PAGE_SHIFT,
+ (u64)lpfn << PAGE_SHIFT,
-:530: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#530: FILE: drivers/gpu/drm/i915/i915_ttm_buddy_manager.c:268:
+ ret = drm_buddy_alloc_blocks(mm, start,
+ start + size,
total: 0 errors, 2 warnings, 2 checks, 534 lines checked
d80a1c8767fe drm: implement top-down allocation method
847e2fae2fa6 drm: implement a method to free unused pages
-:132: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#132: FILE: drivers/gpu/drm/i915/i915_ttm_buddy_manager.c:105:
+ drm_buddy_block_trim(mm,
+ original_size,
total: 0 errors, 0 warnings, 1 checks, 97 lines checked
84642da93b74 drm/amdgpu: move vram inline functions into a header
-:12: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#12:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 51 lines checked
84592517e46b drm/amdgpu: add drm buddy support to amdgpu
-:51: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#51: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h:41:
+ uint32_t mem_type;
-:194: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#194: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h:45:
+ struct mutex lock;
-:272: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#272: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:254:
+ if (drm_buddy_alloc_blocks(mm, rsv->start, rsv->start + rsv->size,
+ rsv->size, mm->chunk_size, &rsv->block,
-:330: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rsv->start <= start'
#330: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:328:
+ if ((rsv->start <= start) &&
+ (start < (rsv->start + rsv->size))) {
-:340: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rsv->start <= start'
#340: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:336:
+ if ((rsv->start <= start) &&
+ (start < (rsv->start + rsv->size))) {
-:407: CHECK:BRACES: Unbalanced braces around else statement
#407: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:391:
+ else {
-:440: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#440: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:420:
+ BUG_ON(min_page_size < mm->chunk_size);
-:483: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#483: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:444:
+ r = drm_buddy_alloc_blocks(mm, (u64)place->fpfn << PAGE_SHIFT,
+ (u64)lpfn << PAGE_SHIFT,
-:506: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#506: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:466:
+ drm_buddy_block_trim(mm,
+ actual_size,
total: 0 errors, 1 warnings, 8 checks, 590 lines checked
next prev parent reply other threads:[~2022-01-09 14:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 14:19 [PATCH v7 1/6] drm: move the buddy allocator from i915 into common drm Arunpravin
2022-01-09 14:19 ` Arunpravin
2022-01-09 14:19 ` [Intel-gfx] " Arunpravin
2022-01-09 14:19 ` [PATCH v7 2/6] drm: improve drm_buddy_alloc function Arunpravin
2022-01-09 14:19 ` Arunpravin
2022-01-09 14:19 ` [Intel-gfx] " Arunpravin
2022-01-09 14:19 ` [PATCH v7 3/6] drm: implement top-down allocation method Arunpravin
2022-01-09 14:19 ` Arunpravin
2022-01-09 14:19 ` [Intel-gfx] " Arunpravin
2022-01-09 14:19 ` [PATCH v7 4/6] drm: implement a method to free unused pages Arunpravin
2022-01-09 14:19 ` Arunpravin
2022-01-09 14:19 ` [Intel-gfx] " Arunpravin
2022-01-09 14:19 ` [PATCH v7 5/6] drm/amdgpu: move vram inline functions into a header Arunpravin
2022-01-09 14:19 ` Arunpravin
2022-01-09 14:19 ` [Intel-gfx] " Arunpravin
2022-01-09 14:19 ` [PATCH v7 6/6] drm/amdgpu: add drm buddy support to amdgpu Arunpravin
2022-01-09 14:19 ` Arunpravin
2022-01-09 14:19 ` [Intel-gfx] " Arunpravin
2022-01-10 9:58 ` kernel test robot
2022-01-10 9:58 ` kernel test robot
2022-01-09 14:43 ` Patchwork [this message]
2022-01-09 14:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v7,1/6] drm: move the buddy allocator from i915 into common drm Patchwork
2022-01-09 15:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-09 16:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-01-10 8:03 ` [PATCH v7 1/6] " Christian König
2022-01-10 8:03 ` Christian König
2022-01-10 8:03 ` [Intel-gfx] " Christian König
2022-01-11 20:12 ` Arunpravin
2022-01-11 20:12 ` Arunpravin
2022-01-11 20:12 ` [Intel-gfx] " Arunpravin
2022-01-10 9:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164173943420.4447.3401337905466288273@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=arunpravin.paneerselvam@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.