All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Laibin Qiu <qiulaibin@huawei.com>,
	ming.lei@redhat.com, john.garry@huawei.com
Cc: akpm@linux-foundation.org, bvanassche@acm.org,
	linux-kernel@vger.kernel.org, hare@suse.de,
	linux-block@vger.kernel.org, andriy.shevchenko@linux.intel.com,
	martin.petersen@oracle.com
Subject: Re: [PATCH -next V5] blk-mq: fix tag_get wait task can't be awakened
Date: Thu, 13 Jan 2022 12:52:35 -0700	[thread overview]
Message-ID: <164210355584.171739.7914692743898015276.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220113025536.1479653-1-qiulaibin@huawei.com>

On Thu, 13 Jan 2022 10:55:36 +0800, Laibin Qiu wrote:
> In case of shared tags, there might be more than one hctx which
> allocates from the same tags, and each hctx is limited to allocate at
> most:
>         hctx_max_depth = max((bt->sb.depth + users - 1) / users, 4U);
> 
> tag idle detection is lazy, and may be delayed for 30sec, so there
> could be just one real active hctx(queue) but all others are actually
> idle and still accounted as active because of the lazy idle detection.
> Then if wake_batch is > hctx_max_depth, driver tag allocation may wait
> forever on this real active hctx.
> 
> [...]

Applied, thanks!

[1/1] blk-mq: fix tag_get wait task can't be awakened
      commit: 180dccb0dba4f5e84a4a70c1be1d34cbb6528b32

Best regards,
-- 
Jens Axboe



  parent reply	other threads:[~2022-01-13 19:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13  2:55 [PATCH -next V5] blk-mq: fix tag_get wait task can't be awakened Laibin Qiu
2022-01-13 10:51 ` Andy Shevchenko
2022-01-13 19:52 ` Jens Axboe [this message]
2022-01-27  1:32 ` Guenter Roeck
2022-01-27 17:28   ` Jens Axboe
2022-01-27 18:04     ` Guenter Roeck
2022-01-27 18:06       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164210355584.171739.7914692743898015276.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.de \
    --cc=john.garry@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=qiulaibin@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.