From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>,
Jeff Layton <jlayton@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-mm@kvack.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] remove dependence of inode_congested()
Date: Mon, 31 Jan 2022 15:03:53 +1100 [thread overview]
Message-ID: <164360127045.4233.2606812444285122570.stgit@noble.brown> (raw)
Miklos pointed out that the filesystems which set the bdi congestion
flags do gain some value from that, and simply removing the code is not
appropriate.
Specifically, readahead and/or writeback are skipped when the congestion
flags are set.
We can mostly move this skipping into the filesystem.
->readahead can do nothing if reads are congested.
->writepage and ->wrtepages can do nothing for WB_SYNC_NONE if writes
are congested.
Currently only *some* WB_SYNC_NONE writes are skipped due to congestion.
Those from sync_file_range() and those used for page migration are not.
Also, shrink_page_list() will now cause PageActive to be set if
->writepage skips due to congestion.
I don't expect these changes to be a problem, but I have no experience
to base that on.
Review/comments most welcome,
Thanks,
NeilBrown
---
NeilBrown (3):
fuse: remove reliance on bdi congestion
nfs: remove reliance on bdi congestion
ceph: remove reliance on bdi congestion
fs/ceph/addr.c | 22 +++++++++++++---------
fs/ceph/super.c | 1 +
fs/ceph/super.h | 1 +
fs/nfs/write.c | 12 ++++++++++--
include/linux/nfs_fs_sb.h | 1 +
5 files changed, 26 insertions(+), 11 deletions(-)
--
Signature
next reply other threads:[~2022-01-31 4:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 4:03 NeilBrown [this message]
2022-01-31 4:03 ` [PATCH 1/3] fuse: remove reliance on bdi congestion NeilBrown
2022-01-31 4:28 ` Matthew Wilcox
2022-01-31 4:47 ` NeilBrown
2022-01-31 10:21 ` Miklos Szeredi
2022-01-31 13:12 ` Matthew Wilcox
2022-01-31 23:00 ` NeilBrown
2022-02-01 2:01 ` Matthew Wilcox
2022-02-01 3:28 ` NeilBrown
2022-02-01 4:06 ` Matthew Wilcox
2022-02-07 0:47 ` NeilBrown
2022-01-31 4:03 ` [PATCH 3/3] ceph: " NeilBrown
2022-01-31 4:03 ` [PATCH 2/3] nfs: " NeilBrown
2022-01-31 4:22 ` Matthew Wilcox
2022-01-31 4:55 ` NeilBrown
2022-01-31 13:15 ` Matthew Wilcox
2022-01-31 21:38 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164360127045.4233.2606812444285122570.stgit@noble.brown \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.