All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Hannes Reinecke <hare@suse.de>, Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Fix the maximum minor value is blk_alloc_ext_minor()
Date: Mon, 28 Mar 2022 06:36:24 -0600	[thread overview]
Message-ID: <164847098496.6880.2578259301021456744.b4-ty@kernel.dk> (raw)
In-Reply-To: <cc17199798312406b90834e433d2cefe8266823d.1648306232.git.christophe.jaillet@wanadoo.fr>

On Sat, 26 Mar 2022 15:50:46 +0100, Christophe JAILLET wrote:
> ida_alloc_range(..., min, max, ...) returns values from min to max,
> inclusive.
> 
> So, NR_EXT_DEVT is a valid idx returned by blk_alloc_ext_minor().
> 
> This is an issue because in device_add_disk(), this value is used in:
>    ddev->devt = MKDEV(disk->major, disk->first_minor);
> and NR_EXT_DEVT is '(1 << MINORBITS)'.
> 
> [...]

Applied, thanks!

[1/1] block: Fix the maximum minor value is blk_alloc_ext_minor()
      commit: d1868328dec5ae2cf210111025fcbc71f78dd5ca

Best regards,
-- 
Jens Axboe



      parent reply	other threads:[~2022-03-28 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26 14:50 [PATCH] block: Fix the maximum minor value is blk_alloc_ext_minor() Christophe JAILLET
2022-03-28  8:20 ` Jan Kara
2022-03-28 12:36 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164847098496.6880.2578259301021456744.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=hare@suse.de \
    --cc=jack@suse.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.