From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chesnokov Gleb <Chesnokov.G@raidix.com>, linux-scsi@vger.kernel.org
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 2/2] qla2xxx: Fix missed DMA unmap for aborted cmds
Date: Mon, 2 May 2022 20:50:26 -0400 [thread overview]
Message-ID: <165153834205.24012.4172910984795478484.b4-ty@oracle.com> (raw)
In-Reply-To: <AS8PR10MB4952D545F84B6B1DFD39EC1E9DEE9@AS8PR10MB4952.EURPRD10.PROD.OUTLOOK.COM>
On Fri, 15 Apr 2022 12:42:29 +0000, Chesnokov Gleb wrote:
> Aborting commands that have already been sent to the firmware can
> cause BUG in qlt_free_cmd(): BUG_ON(cmd->sg_mapped)
>
> For instance:
> - command passes rdx_to_xfer state, maps sgl, sends to the
> fimware
> - reset occurs, qla2xxx performs ISP error recovery,
> aborts the command
> - target stack calls qlt_abort_cmd() and then qlt_free_cmd()
> - BUG_ON(cmd->sg_mapped) in qlt_free_cmd() occurs because sgl was not
> unmapped
>
> [...]
Applied to 5.18/scsi-fixes, thanks!
[2/2] qla2xxx: Fix missed DMA unmap for aborted cmds
https://git.kernel.org/mkp/scsi/c/26f9ce53817a
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2022-05-04 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 12:42 [PATCH 2/2] qla2xxx: Fix missed DMA unmap for aborted cmds Chesnokov Gleb
2022-04-19 19:41 ` Himanshu Madhani
2022-04-20 14:42 ` Chesnokov Gleb
2022-04-20 19:09 ` Himanshu Madhani
2022-04-25 18:49 ` Chesnokov Gleb
2022-04-27 16:52 ` Himanshu Madhani
2022-05-03 0:50 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165153834205.24012.4172910984795478484.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Chesnokov.G@raidix.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.