From: patchwork-bot+netdevbpf@kernel.org
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
b.a.t.m.a.n@lists.open-mesh.org, sven@narfation.org,
felix@kaechele.ca
Subject: Re: [PATCH 1/1] batman-adv: Don't skb_split skbuffs with frag_list
Date: Tue, 10 May 2022 01:20:12 +0000 [thread overview]
Message-ID: <165214561288.15844.2929287601845577779.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220508132110.20451-2-sw@simonwunderlich.de>
Hello:
This patch was applied to netdev/net.git (master)
by Simon Wunderlich <sw@simonwunderlich.de>:
On Sun, 8 May 2022 15:21:10 +0200 you wrote:
> From: Sven Eckelmann <sven@narfation.org>
>
> The receiving interface might have used GRO to receive more fragments than
> MAX_SKB_FRAGS fragments. In this case, these will not be stored in
> skb_shinfo(skb)->frags but merged into the frag list.
>
> batman-adv relies on the function skb_split to split packets up into
> multiple smaller packets which are not larger than the MTU on the outgoing
> interface. But this function cannot handle frag_list entries and is only
> operating on skb_shinfo(skb)->frags. If it is still trying to split such an
> skb and xmit'ing it on an interface without support for NETIF_F_FRAGLIST,
> then validate_xmit_skb() will try to linearize it. But this fails due to
> inconsistent information. And __pskb_pull_tail will trigger a BUG_ON after
> skb_copy_bits() returns an error.
>
> [...]
Here is the summary with links:
- [1/1] batman-adv: Don't skb_split skbuffs with frag_list
https://git.kernel.org/netdev/net/c/a063f2fba3fa
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-05-10 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 13:21 [PATCH 0/1] pull request for net: batman-adv 2022-05-08 Simon Wunderlich
2022-05-08 13:21 ` Simon Wunderlich
2022-05-08 13:21 ` [PATCH 1/1] batman-adv: Don't skb_split skbuffs with frag_list Simon Wunderlich
2022-05-10 1:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165214561288.15844.2929287601845577779.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=felix@kaechele.ca \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.