From: "irqchip-bot for Miaoqian Lin" <tip-bot2@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Miaoqian Lin <linmq006@gmail.com>, Marc Zyngier <maz@kernel.org>,
tglx@linutronix.de
Subject: [irqchip: irq/irqchip-fixes] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init
Date: Thu, 09 Jun 2022 16:50:29 -0000 [thread overview]
Message-ID: <165479342917.4207.8528273657753463802.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20220601080930.31005-2-linmq006@gmail.com>
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: f4b98e314888cc51486421bcf6d52852452ea48b
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/f4b98e314888cc51486421bcf6d52852452ea48b
Author: Miaoqian Lin <linmq006@gmail.com>
AuthorDate: Wed, 01 Jun 2022 12:09:25 +04:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Thu, 09 Jun 2022 17:36:57 +01:00
irqchip/gic/realview: Fix refcount leak in realview_gic_of_init
of_find_matching_node_and_match() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-2-linmq006@gmail.com
---
drivers/irqchip/irq-gic-realview.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c
index b4c1924..38fab02 100644
--- a/drivers/irqchip/irq-gic-realview.c
+++ b/drivers/irqchip/irq-gic-realview.c
@@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent)
/* The PB11MPCore GIC needs to be configured in the syscon */
map = syscon_node_to_regmap(np);
+ of_node_put(np);
if (!IS_ERR(map)) {
/* new irq mode with no DCC */
regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,
next prev parent reply other threads:[~2022-06-09 16:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 8:09 [PATCH 0/6] irqchip: Fix some refcount leaks Miaoqian Lin
2022-06-01 8:09 ` Miaoqian Lin
2022-06-01 8:09 ` [PATCH 1/6] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Miaoqian Lin
2022-06-01 8:09 ` Miaoqian Lin
2022-06-09 16:50 ` irqchip-bot for Miaoqian Lin [this message]
2022-06-01 8:09 ` [PATCH 2/6] irqchip/apple-aic: Fix refcount leak in build_fiq_affinity Miaoqian Lin
2022-06-01 8:09 ` Miaoqian Lin
2022-06-09 16:50 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Miaoqian Lin
2022-06-01 8:09 ` [PATCH 3/6] irqchip/apple-aic: Fix refcount leak in aic_of_ic_init Miaoqian Lin
2022-06-01 8:09 ` Miaoqian Lin
2022-06-09 16:50 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Miaoqian Lin
2022-06-01 8:09 ` [PATCH 4/6] irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions Miaoqian Lin
2022-06-01 8:09 ` Miaoqian Lin
2022-06-09 16:50 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Miaoqian Lin
2022-06-01 8:09 ` [PATCH 5/6] irqchip/gic-v3: Fix refcount leak " Miaoqian Lin
2022-06-01 8:09 ` Miaoqian Lin
2022-06-09 16:50 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Miaoqian Lin
2022-06-01 8:09 ` [PATCH 6/6] irqchip/realtek-rtl: Fix refcount leak in map_interrupts Miaoqian Lin
2022-06-01 8:09 ` Miaoqian Lin
2022-06-09 16:50 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Miaoqian Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165479342917.4207.8528273657753463802.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.